fix(container): surface clear error when PR branch is deleted - #18
Merged
Conversation
When a user starts a session on a merged PR whose branch was deleted, gh pr checkout fails silently and the frontend enters a reconnect loop. - Entrypoint now emits structured error events to stdout on clone/checkout failure so the SSE pipeline relays them to the frontend - Frontend parses the new error event type and displays the message inline - Done SSE event includes status field so the frontend can distinguish completed vs failed sessions
|
helPRs session created for this PR. Skill: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{"type":"error","error":{"message":"..."}}events to stdout whengh repo cloneorgh pr checkoutfails, so the SSE pipeline relays them to the frontenderrorevent type and displays the message inline in the conversationstatusfield so the frontend can distinguishcompletedvsfailedsessions (previously always setcompleted)Before: deleted-branch sessions fail silently, frontend enters reconnect loop
After: user sees "Failed to checkout PR #N. The branch may have been deleted after the PR was merged." and status badge shows
failedTest plan
failedimmediately)make lintpassesmake testpasses (2 pre-existing flaky webhook dispatcher tests excluded)