fix(container): accept github_installation_id in session creation - #23
Merged
Conversation
The session creation endpoint expected an internal UUID for installation_id, but the frontend sends the github_installation_id integer from the URL. Changed CreateSessionRequest.installation_id to int and use get_installation_by_github_id() for lookup, consistent with all other installation routes.
|
helPRs session created for this PR. Skill: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /containers/sessions) expected an internal UUID forinstallation_id, but the frontend sends thegithub_installation_idinteger from URL paramsCreateSessionRequest.installation_idfromuuid.UUIDtointget_installation_by_github_id()for lookup, consistent with all other installation routespost_results_to_prcolumn) also discovered and applied during E2E QATest plan
make lintpasses (ruff + eslint)make testpasses (270/272, 2 known flaky dispatcher tests)