defro drx pluse #156

fifeek0 · 2025-09-16T15:38:18Z

Summary

This pull request introduces comprehensive support for Tech HVAC recuperation (ventilation) systems within the Home Assistant integration. It adds new binary sensors to monitor filter replacement and system status, introduces button entities for controlling recuperation features (filter reset, party mode, quick boost), and extends the integration's constants and platform support to handle these new capabilities.

Recuperation System Support

Added detection logic for recuperation systems in binary_sensor.py and button.py.
Enabled conditional creation of related entities when flow sensors are present in the system.

New Entities for Recuperation Control and Monitoring

Implemented new binary sensors:
- FilterReplacementSensor for filter replacement needs.
- RecuperationSystemStatusSensor for operational system status.
Added new button entities:
- FilterResetButton
- PartyModeButton
- QuickBoostButton
These allow users to reset filter timers and activate party/boost modes directly from Home Assistant.

Platform and Constants Extension

Extended supported platforms to include:
- Platform.FAN
- Platform.NUMBER
- Platform.SELECT
- Platform.BUTTON
- Platform.SWITCH
Defined new constants for:
- Recuperation system types
- Flow sensors
- Temperature sensors
- Speed controls
- Party mode
- Gear control
- Filter management
- Related configuration keys and ranges

Integration and State Management

Updated integration setup to store the config entry in the coordinator.
Added logic to load filter reset dates from persistent storage for accurate filter usage tracking.

These changes enhance the integration’s ability to monitor and control recuperation units, giving users improved diagnostics and direct control over key ventilation features.

…ch entities - Implemented number controls for recuperation systems, including party mode, speed configurations, filter alarms, and ventilation parameters. - Added select controls for fan modes and gear settings with Polish language support. - Introduced a flow balancing switch for managing airflow in recuperation systems. - Enhanced logging for better debugging and tracking of state changes.

…handling; update Tech class headers to include User-Agent

Enhance RecuperationEfficiencySensor with improved logging and error …

Fixes mariusz-ostoja-swierczynski#157

anarion80 · 2025-09-18T10:23:54Z

Thanks for the PR. Some big changes here. I had to update the main with some fixes and devenv updates to check the PR.
Tests are working, but when adding all controllers from demo account (test/test), there is one error:

2025-09-18 12:17:47.239 ERROR (MainThread) [homeassistant.components.fan] Error while setting up tech platform for fan: Can't instantiate abstract class TileFanEntity without an implementation for abstract method 'get_state'
Traceback (most recent call last):
  File "/home/anarion/Documents/Repos/tech-controllers/.devenv/state/venv/lib/python3.13/site-packages/homeassistant/helpers/entity_platform.py", line 451, in _async_setup_platform
    await asyncio.shield(awaitable)
  File "/home/anarion/Documents/Repos/tech-controllers/config/custom_components/tech/fan.py", line 75, in async_setup_entry
    entities.append(TileFanEntity(tile, coordinator, config_entry))
                    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: Can't instantiate abstract class TileFanEntity without an implementation for abstract method 'get_state'

…d to TileFanEntity

Refactor import statements for flow constants and add get_state metho…

fifeek0 · 2025-09-18T15:15:33Z

Thanks for the PR. Some big changes here. I had to update the main with some fixes and devenv updates to check the PR. Tests are working, but when adding all controllers from demo account (test/test), there is one error:

2025-09-18 12:17:47.239 ERROR (MainThread) [homeassistant.components.fan] Error while setting up tech platform for fan: Can't instantiate abstract class TileFanEntity without an implementation for abstract method 'get_state'
Traceback (most recent call last):
  File "/home/anarion/Documents/Repos/tech-controllers/.devenv/state/venv/lib/python3.13/site-packages/homeassistant/helpers/entity_platform.py", line 451, in _async_setup_platform
    await asyncio.shield(awaitable)
  File "/home/anarion/Documents/Repos/tech-controllers/config/custom_components/tech/fan.py", line 75, in async_setup_entry
    entities.append(TileFanEntity(tile, coordinator, config_entry))
                    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: Can't instantiate abstract class TileFanEntity without an implementation for abstract method 'get_state'

Now should be ok

anarion80 · 2025-09-18T17:20:19Z

Now should be ok

Unfortunately, now there is a big problem with tiles.

Previously:

And it was roughly matching the tiles in demo account (after much trial and error):

Now:

They are now devices with 1 entity, and all the other tiles are disconnected from the hub:

Also:

while previously it was just a sensor showing fan rotations like in emodul dashboard:

Changing fan speed then results in an error for such sensors now:

2025-09-18 19:00:41.359 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [140193446247648] Unexpected exception
Traceback (most recent call last):
  File "/home/anarion/Documents/Repos/tech-controllers/.devenv/state/venv/lib/python3.13/site-packages/homeassistant/components/websocket_api/commands.py", line 264, in handle_call_service
    response = await hass.services.async_call(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ...<7 lines>...
    )
    ^
  File "/home/anarion/Documents/Repos/tech-controllers/.devenv/state/venv/lib/python3.13/site-packages/homeassistant/core.py", line 2835, in async_call
    response_data = await coro
                    ^^^^^^^^^^
  File "/home/anarion/Documents/Repos/tech-controllers/.devenv/state/venv/lib/python3.13/site-packages/homeassistant/core.py", line 2878, in _execute_service
    return await target(service_call)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/anarion/Documents/Repos/tech-controllers/.devenv/state/venv/lib/python3.13/site-packages/homeassistant/helpers/service.py", line 850, in entity_service_call
    single_response = await _handle_entity_call(
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
        hass, entity, func, data, call.context
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/home/anarion/Documents/Repos/tech-controllers/.devenv/state/venv/lib/python3.13/site-packages/homeassistant/helpers/service.py", line 922, in _handle_entity_call
    result = await task
             ^^^^^^^^^^
  File "/home/anarion/Documents/Repos/tech-controllers/config/custom_components/tech/fan.py", line 177, in async_set_percentage
    await self._coordinator.api.set_recuperation_speed(self._udid, speed_level, None)
  File "/home/anarion/Documents/Repos/tech-controllers/config/custom_components/tech/tech.py", line 460, in set_recuperation_speed
    raise TechError(400, f"Invalid speed level: {speed_level}")
custom_components.tech.tech.TechError: (400, 'Invalid speed level: 0.99')

(although this particular error might be a bug regardless).

Please try to debug and check with demo account as well.

daroga0002

I have looked in fast way into this (without going into logic and deep review) so left few comments

daroga0002 · 2025-10-01T06:26:56Z

.DS_Store

this shouldnt be added

daroga0002 · 2025-10-01T06:27:44Z

custom_components/.DS_Store

shouldnt be here

daroga0002 · 2025-10-01T06:35:33Z

custom_components/tech/sensor.py

-            entities.append(TileFanSensor(tile, coordinator, config_entry))
+            # Check if this fan is handled by the fan platform (recuperation)
+            description = tile[CONF_PARAMS].get(CONF_DESCRIPTION, "").lower()
+            if not any(keyword in description for keyword in ["recuperation", "rekuperacja", "ventilation", "wentylacja"]):


this looks some bad assumption, tech api currently supports:

Available values : en, fr, it, es, nl, pl, de, cs, sk, hu, ro, lt, et, ru, si, hr

so assuming it will not work for other languages properly and we have a lot of users using those languages

daroga0002 · 2025-10-01T06:44:40Z

custom_components/tech/const.py

+
+# Direct gear control settings
+GEAR_CONTROL_IDO_ID = 1833
+GEAR_OPTIONS = {


be consistent and use english for comments everywhere

daroga0002 · 2025-10-01T06:51:31Z

custom_components/tech/binary_sensor.py

+    @property
+    def is_on(self) -> bool | None:
+        """Return True if filter replacement is needed."""
+        # Calculate if filter replacement is needed based on usage days


What is source of max days and other constants?

Does device record them or what will happen when those will be passed?

daroga0002 · 2025-10-01T06:54:03Z

custom_components/tech/binary_sensor.py

+                        for flow_sensor in [RECUPERATION_EXHAUST_FLOW, RECUPERATION_SUPPLY_FLOW, RECUPERATION_SUPPLY_FLOW_ALT]:
+                            if flow_sensor["txt_id"] == widget_txt_id:
+                                flow_value = widget_data.get("value", 0)
+                                if flow_value and flow_value > 0:


we dont need to check flow_value exists as above you always make it using:
flow_value = widget_data.get("value", 0)

daroga0002 · 2025-10-01T07:00:11Z

custom_components/tech/select.py

+
+        # Define options with Polish names
+        self._attr_options = [
+            "Zatrzymaj wentylator",


We should support all languages from tech API as minimum:

Options: 'en', 'fr', 'it', 'es', 'nl', 'pl', 'de', 'cs', 'sk', 'hu', 'ro', 'lt', 'et', 'ru', 'si', 'hr'

As we got a users from those countries also

Yes, this is all in the language file returned by the API:
https://emodul.eu/api/v1/i18n/en
https://emodul.eu/api/v1/i18n/pl

so you need to use the key/value from there

daroga0002 · 2025-10-01T07:00:47Z

custom_components/tech/select.py

+
+        # Map option name to value
+        option_value_map = {
+            "Zatrzymaj wentylator": 0,


We should not use only Polish

daroga0002 · 2025-10-01T07:01:06Z

custom_components/tech/select.py

+    async def async_select_option(self, option: str) -> None:
+        """Change the selected gear."""
+        gear_mapping = {
+            "Zatrzymaj": 0,


Not only Polish

daroga0002 · 2025-10-01T07:02:08Z

custom_components/tech/tech.py

+        self.headers = {
+            "Accept": "application/json",
+            "Accept-Encoding": "gzip",
+            "User-Agent": "TechController/1.0 (Home Assistant Integration)"


it is hard to tell how tech company will react on that, this will give them chance to cut off this integration very easy by blocking this header

fifeek0 and others added 4 commits September 16, 2025 17:29

add defro recuperator

23c7262

Enhance RecuperationEfficiencySensor with improved logging and error …

6788f52

…handling; update Tech class headers to include User-Agent

Merge pull request #1 from fifeek0/main

2325a72

Enhance RecuperationEfficiencySensor with improved logging and error …

fifeek0 marked this pull request as ready for review September 17, 2025 16:18

anarion80 added 2 commits September 18, 2025 12:21

🧑💻 Update devenv and dependencies

ae0d5be

🐛 Add subentries_data to ConfigEntry

4325e23

Fixes mariusz-ostoja-swierczynski#157

fifeek0 and others added 2 commits September 18, 2025 16:14

Refactor import statements for flow constants and add get_state metho…

afcde62

…d to TileFanEntity

Merge pull request #2 from fifeek0/main

b5965a8

Refactor import statements for flow constants and add get_state metho…

fifeek0 changed the title ~~defo drx pluse~~ defro drx pluse Sep 19, 2025

daroga0002 reviewed Oct 1, 2025

View reviewed changes

defro drx pluse #156

Are you sure you want to change the base?

defro drx pluse #156

Uh oh!

Conversation

fifeek0 commented Sep 16, 2025

Summary

Recuperation System Support

New Entities for Recuperation Control and Monitoring

Platform and Constants Extension

Integration and State Management

Uh oh!

anarion80 commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fifeek0 commented Sep 18, 2025

Uh oh!

anarion80 commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daroga0002 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anarion80 Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

anarion80 commented Sep 18, 2025 •

edited

Loading

anarion80 commented Sep 18, 2025 •

edited

Loading

anarion80 Oct 1, 2025 •

edited

Loading