-
Notifications
You must be signed in to change notification settings - Fork 75
🐛 Small updates #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Small updates #160
Conversation
@anarion80 addition of dependabot config for github actions will also require adding two GitHub labels for this repo (if not existing):
Then Dependabot will automatically label those changes on PRs |
I tried adding Dependabot before: 39f2610 but then it turned out that to enable it on the repo one needs to set appropriate settings: https://docs.github.com/en/code-security/getting-started/dependabot-quickstart-guide#enabling-dependabot-for-your-repository for which I don't have access. And I decided not to bother Mariusz to do that :) |
hmm, yup it will be problem :/ This integration has some number of users which are using it actively in their Home Assistant setup. Maybe we can consider moving this code to separate organization (the best path will be official transferring repo there). GitHub is currently allowing to create organization for free with all features (in case of public repos) https://github.com/organizations/plan So then potentially we can have even few admins/contributors taking care of this codebase and have management priviliges of repo/organization what will cause we will be able have redundancy around it. License is MIT so technically we can just fork/copy repo but I would rather avoid this as we building some trust around users. @mariusz-ostoja-swierczynski does you will be willing to transfer this repo to separate organization to allow future development without bothering you around any repo setup or etc.?? PS |
@anarion80 I opened new issue to follow up topic above Regarding dependabot config, even if this is not enabled we can just merge (then it will be not working probably here, but will be propagated to Forks) or I can just remove it. I have running this code for few days with L-X Wifi controller and didnt found any issues. I also performed some testing using test account from Tech Sterowniki and also didnt observed any issues so can you take a look and if everything will be ok then merge? |
This pull request focuses on improving code clarity, documentation, and maintainability for the Tech Controllers Home Assistant integration. The main changes include updating workflow dependencies, enhancing docstrings for better developer understanding, refactoring asset utilities, and making minor code improvements for consistency.
Workflow and Dependency Updates:
.github/dependabot.yaml
configuration to automate dependency updates for GitHub Actions.actions/checkout
andactions/setup-python
for improved reliability and security. [1] [2] [3] [4]Code Documentation and Clarity:
custom_components/tech/__init__.py
,binary_sensor.py
,climate.py
, andconfig_flow.py
) to clarify function purposes, arguments, and return values for easier onboarding and maintenance. [1] [2] [3] [4] [5] [6] [7]Asset Utilities Refactor:
custom_components/tech/assets.py
to improve type safety, update docstrings, introduce a constant for redacted values, and clarify translation and icon lookup logic. This makes asset handling more robust and easier to extend.Minor Codebase Improvements:
ruff-check
hook for auto-fixing linter issues.config_flow.py
.These changes collectively enhance the integration’s reliability, developer experience, and future maintainability.