-
Notifications
You must be signed in to change notification settings - Fork 13
Gpu data #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gpu data #86
Conversation
This reverts commit 4ed9897.
Just noticed VRAM capacity is not shown, and seems to be conflicting with Maximum VRAM Capacity |
nvm it is shown... but should be noted they should probably be MT/s rather than Mhz. |
Hi, I think this is pretty go to go into beta now, let me know if you see anything wrong with it so far @markasoftware |
Sorry for the late response! Overall looks really good, I'm fine to merge it basically whatever since it's already a huge improvement over what we have right now. That being said there are still a few things that could be improved:
|
I think this should be good to go for now. Can always fix things with later pull requests |
Nice! Some notes:
I'd also prefer if the scraping code was open-sourced somewhere, even if it's just random python scripts in a separate repo that you control. This is a massive achievement and certainly the biggest update to SpecDB since its inception! |
@markasoftware I did edit some of the matcher stuff, and added another one I think. If you see any obvious ones without a benchmark I'll have a look but any of the new ish graphics cards should have them |
Gpu data, not ready to be merged yet, just opening as its close.