Skip to content

2025-04-15 - v3 Re-write#10

Merged
markbattistella merged 4 commits into
mainfrom
mb/date-localisation
Apr 14, 2025
Merged

2025-04-15 - v3 Re-write#10
markbattistella merged 4 commits into
mainfrom
mb/date-localisation

Conversation

@markbattistella
Copy link
Copy Markdown
Owner

Pull Request

Important

Please ensure you have named your pull request with the proper naming convention. This is usually in the YYYY-MM-DD - format. This aids in maintaining the codebase in a consistent and uniform format.

Description

  • Full re-write of the package
  • Western and Chinese zodiacs now have many more properties
  • Western has the ability to use .tropical, .equalLength, .sidereal, and .astronomicalIAU
  • Western can also pass in .custom([Zodiac]) if you have your own date ranges
  • Removes reliance on English localisation
  • Swift 6 concurrency valid
  • Cleaner, smarter, and optimised validation
  • Better error messages
  • Much more, so please read the README

Caution

This is a breaking change version upgrade. Since this was completely re-written many things in v2.x do not apply or have been reworked. Proceed with caution.

Local Testing

  • I have tested these changes on a local environment and confirm they work as expected.

Checklist

  • My changes generate no new warnings or errors.
  • I have performed a self-review of my own code/documentation.
  • I have updated the change log file (if applicable), linking to the relevant sections.
  • I have checked and corrected any mis-spellings and grammatical errors.
  • I have ensured that any dependencies are updated and documented.
  • I have included relevant unit tests and they pass.
  • I have added or updated documentation as needed.

Additional Notes

@markbattistella markbattistella merged commit c8dcb26 into main Apr 14, 2025
1 of 2 checks passed
@markbattistella markbattistella deleted the mb/date-localisation branch April 14, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant