Skip to content

ci: add environment checker workflow#1

Draft
shakthiprasadpai wants to merge 4 commits into
marketcalls:masterfrom
shakthiprasadpai:ci/add-check-env
Draft

ci: add environment checker workflow#1
shakthiprasadpai wants to merge 4 commits into
marketcalls:masterfrom
shakthiprasadpai:ci/add-check-env

Conversation

@shakthiprasadpai

@shakthiprasadpai shakthiprasadpai commented Dec 18, 2025

Copy link
Copy Markdown

Adds GitHub Actions workflow that installs declared dependencies and runs . The job fails if environment or imports are broken, preventing dependency regressions in PRs.


Summary by cubic

Adds a GitHub Actions workflow that installs dependencies, runs an environment check, lints, and runs tests on pushes and PRs. It fails fast to prevent dependency and import regressions.

  • New Features
    • "Check environment" workflow for push and pull_request on ubuntu-latest with Python 3.12.
    • Installs deps from pyproject.toml and runs scripts/check_env.py.
    • Adds lint/test via ruff and pytest; runs pre-commit hooks in CI (.pre-commit-config included).
    • Adds Ruff config in pyproject; updates README with workflow badge, quick check, and pre-commit setup.

Written for commit b54836f. Summary will update automatically on new commits.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (all 1 issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name=".github/workflows/check-env.yml">

<violation number="1" location=".github/workflows/check-env.yml:26">
P1: `tomllib.loads()` expects a string but receives bytes from binary file read. This will raise a `TypeError` and fail the workflow. Use `tomllib.load()` with the binary file object instead.</violation>
</file>

Since this is your first cubic review, here's how it works:

  • cubic automatically reviews your code and comments on bugs and improvements
  • Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
  • Ask questions if you need clarification on any suggestion

Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR

Comment thread .github/workflows/check-env.yml
@shakthiprasadpai shakthiprasadpai marked this pull request as draft December 18, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant