PDP-975: Fix copyright validation clone issues#37
Merged
SameeraPriyathamTadikonda merged 1 commit intomainfrom Feb 23, 2026
Merged
PDP-975: Fix copyright validation clone issues#37SameeraPriyathamTadikonda merged 1 commit intomainfrom
SameeraPriyathamTadikonda merged 1 commit intomainfrom
Conversation
Contributor
SameeraPriyathamTadikonda
commented
Feb 23, 2026
SameeraPriyathamTadikonda
commented
- Replace shallow clone with full clone using --single-branch and --no-tags
- Remove timeout to let git handle its own connection timing
- Resolves 'error processing shallow info' and timeout issues for large repositories
- Replace shallow clone with full clone using --single-branch and --no-tags - Remove timeout to let git handle its own connection timing - Resolves 'error processing shallow info' and timeout issues for large repositories
Copilot started reviewing on behalf of
SameeraPriyathamTadikonda
February 23, 2026 20:58
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix clone issues for large repositories in the copyright validation process. The change removes the 120-second timeout from the git clone subprocess call to address "error processing shallow info" and timeout issues.
Changes:
- Removed the timeout parameter from the git clone subprocess.run call in the download_files method
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -314,7 +314,7 @@ def download_files(self, file_paths): | |||
| token = self.headers['Authorization'].replace('token ','') | |||
| auth_clone_url = f"https://x-access-token:{token}@{GHES_URL.replace('https://','')}/{self.repo_full_name}.git" | |||
| # Fast full clone - single branch, no tags for speed and reliability | |||
There was a problem hiding this comment.
The comment on line 316 says "Fast full clone" but the command uses --single-branch and --no-tags, which is not a full clone. A full clone would include all branches and tags. Consider updating the comment to accurately describe the clone strategy, such as "Single-branch clone without tags for speed and reliability".
Suggested change
| # Fast full clone - single branch, no tags for speed and reliability | |
| # Fast single-branch clone without tags for speed and reliability |
jsvoboda-prgs
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.