Skip to content

fix: typescript fixes - #423

Merged
DylanPiercey merged 1 commit into
mainfrom
type-fixes-12-8-25
Dec 8, 2025
Merged

fix: typescript fixes#423
DylanPiercey merged 1 commit into
mainfrom
type-fixes-12-8-25

Conversation

@DylanPiercey

Copy link
Copy Markdown
Contributor

No description provided.

@changeset-bot

changeset-bot Bot commented Dec 8, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 246675d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@marko/language-tools Patch
@marko/language-server Patch
@marko/type-check Patch
marko-vscode Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Dec 8, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

This PR adds changeset entries for four packages and relaxes restrictions on rendering unknown templates. Type declarations in packages/language-tools/marko.internal.d.ts broaden generic constraints (e.g., renderTemplate, forOfTag, forOfAttrTag), change TemplateRenderer to fallback to DefaultRenderer, and remove MergeOptionalScopes. Script extraction logic was updated: emitted async method naming is conditional based on API, and runtime API detection now prioritizes tag.var, adds mappings for several tag kinds, and removes the module-code case.

Pre-merge checks and finishing touches

❌ Failed checks (2 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix: typescript fixes' is vague and generic, using non-descriptive language that doesn't convey meaningful information about the specific changes in the changeset. Consider using a more specific title that describes the actual changes, such as 'fix: relax unknown template restrictions and restrict script type-checking to tags api' to better reflect the substantive modifications.
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess whether a description relates to the changeset. Add a pull request description that explains the changes, their motivation, and impact on the codebase.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8c3f3da and 246675d.

⛔ Files ignored due to path filters (4)
  • packages/language-server/src/__tests__/fixtures/script/attr-tags-dynamic-for/__snapshots__/attr-tags-dynamic-for.expected/index.md is excluded by !**/__snapshots__/** and included by **
  • packages/language-server/src/__tests__/fixtures/script/empty-tagname/__snapshots__/empty-tagname.expected/index.ts is excluded by !**/__snapshots__/** and included by **
  • packages/language-server/src/__tests__/fixtures/script/for-tag/__snapshots__/for-tag.expected/index.md is excluded by !**/__snapshots__/** and included by **
  • packages/language-server/src/__tests__/fixtures/script/script/__snapshots__/script.expected/index.ts is excluded by !**/__snapshots__/** and included by **
📒 Files selected for processing (5)
  • .changeset/cyan-rivers-jump.md (1 hunks)
  • .changeset/major-meals-tie.md (1 hunks)
  • packages/language-tools/marko.internal.d.ts (9 hunks)
  • packages/language-tools/src/extractors/script/index.ts (1 hunks)
  • packages/language-tools/src/extractors/script/util/get-runtime-api.ts (2 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@DylanPiercey
DylanPiercey merged commit 7f173d6 into main Dec 8, 2025
4 checks passed
@DylanPiercey
DylanPiercey deleted the type-fixes-12-8-25 branch December 8, 2025 17:06
@github-actions github-actions Bot mentioned this pull request Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant