Skip to content

fix: empty close tag grammar for shiki - #428

Merged
DylanPiercey merged 1 commit into
mainfrom
fix-syntax-highligting-shiki
Dec 12, 2025
Merged

fix: empty close tag grammar for shiki#428
DylanPiercey merged 1 commit into
mainfrom
fix-syntax-highligting-shiki

Conversation

@DylanPiercey

Copy link
Copy Markdown
Contributor

No description provided.

@changeset-bot

changeset-bot Bot commented Dec 12, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 305dbf0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
marko-vscode Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DylanPiercey
DylanPiercey force-pushed the fix-syntax-highligting-shiki branch from ae020f7 to 305dbf0 Compare December 12, 2025 21:57
@DylanPiercey
DylanPiercey merged commit 62fa7dd into main Dec 12, 2025
4 checks passed
@DylanPiercey
DylanPiercey deleted the fix-syntax-highligting-shiki branch December 12, 2025 21:57
@coderabbitai

coderabbitai Bot commented Dec 12, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request updates the syntax highlighting grammar for the Marko Visual Studio Code extension to properly handle empty closing tags in shiki. The changes modify the language grammar patterns to recognize standalone closing tags (</>) alongside existing tag patterns. The grammar rules are updated with new negative lookbehind patterns and refined character class matching to improve closing tag recognition. Additionally, a changeset entry documents this patch-level release.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-syntax-highligting-shiki

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2d8adcd and 305dbf0.

📒 Files selected for processing (2)
  • .changeset/cool-dodos-drive.md (1 hunks)
  • packages/vscode/syntaxes/marko.tmLanguage.json (7 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant