fix: pnpm support when @marko/compiler is a transitive dependency - #431
Conversation
🦋 Changeset detectedLatest commit: 1849e6b The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis change adds a patch release across four packages with updates for pnpm support when 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🔇 Additional comments (2)
✏️ Tip: You can disable this entire section by setting Comment |
The language server works by looking for
@marko/compilerinnode_modules. Sincepnpmhas its fancy.pnpmdirectory with@marko+compiler@x.x.xinstead for transitive dependencies, when the compiler wasn't a direct dependency it wasn't being discovered. Here, when a compiler isn't found we fall back to resolving the compiler from the version ofmarkothat is installed.