Skip to content

Enhancement/workflow editing #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markrai merged 5 commits into from
Mar 31, 2026
Merged

Enhancement/workflow editing #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bae1687
phase 1 of editable workflows complete
markrai Mar 31, 2026
fce2334
increase settings modal width to accomodate new workflows tab
markrai Mar 31, 2026
2c4ddb6
Phase 2 of editable workflows (Dashboard hardening)
markrai Mar 31, 2026
6640678
phase 3 (add lane) implemented
markrai Mar 31, 2026
9a68925
phase 4 (delete) implemented
markrai Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
647 changes: 647 additions & 0 deletions docs/draft/editable-workflow-lanes-analysis.md
View file
Open in desktop

Large diffs are not rendered by default.

1,182 changes: 1,182 additions & 0 deletions docs/draft/mcp_adapter_implementation_plan.md
View file
Open in desktop

Large diffs are not rendered by default.

124 changes: 120 additions & 4 deletions internal/httpapi/routing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,6 +1069,122 @@ func (s *Server) handleBoard(w http.ResponseWriter, r *http.Request, rest []stri
return
}

// POST /api/board/{slug}/workflow - add a new non-done lane before done.
if len(rest) == 2 && rest[1] == "workflow" && r.Method == http.MethodPost {
ctx := s.requestContext(r)
userID, ok := store.UserIDFromContext(ctx)
if !ok {
writeError(w, http.StatusUnauthorized, "UNAUTHORIZED", "unauthorized", nil)
return
}
role, err := s.store.GetProjectRole(ctx, project.ID, userID)
if err != nil || !role.HasMinimumRole(store.RoleMaintainer) {
writeError(w, http.StatusForbidden, "FORBIDDEN", "maintainer or higher required", nil)
return
}

var in struct {
Name string `json:"name"`
}
if err := readJSON(w, r, s.maxBody, &in); err != nil {
return
}
in.Name = strings.TrimSpace(in.Name)
if in.Name == "" {
writeError(w, http.StatusBadRequest, "VALIDATION_ERROR", "name required", map[string]any{"field": "name"})
return
}
if len(in.Name) > 200 {
writeError(w, http.StatusBadRequest, "VALIDATION_ERROR", "invalid workflow column name", map[string]any{"field": "name"})
return
}

col, err := s.store.AddWorkflowColumn(ctx, project.ID, in.Name)
if err != nil {
writeStoreErr(w, err, true)
return
}
s.emitRefreshNeeded(project.ID, "workflow_column_added")
writeJSON(w, http.StatusCreated, workflowColumnJSON{
Key: col.Key,
Name: col.Name,
Color: col.Color,
IsDone: col.IsDone,
Position: col.Position,
})
return
}

// PATCH /api/board/{slug}/workflow/{key} - rename workflow lane label only.
if len(rest) == 3 && rest[1] == "workflow" && r.Method == http.MethodPatch {
ctx := s.requestContext(r)
userID, ok := store.UserIDFromContext(ctx)
if !ok {
writeError(w, http.StatusUnauthorized, "UNAUTHORIZED", "unauthorized", nil)
return
}
role, err := s.store.GetProjectRole(ctx, project.ID, userID)
if err != nil || !role.HasMinimumRole(store.RoleMaintainer) {
writeError(w, http.StatusForbidden, "FORBIDDEN", "maintainer or higher required", nil)
return
}
columnKey := strings.TrimSpace(rest[2])
if columnKey == "" {
writeError(w, http.StatusBadRequest, "VALIDATION_ERROR", "invalid workflow key", map[string]any{"field": "key"})
return
}

var in struct {
Name string `json:"name"`
}
if err := readJSON(w, r, s.maxBody, &in); err != nil {
return
}
in.Name = strings.TrimSpace(in.Name)
if in.Name == "" {
writeError(w, http.StatusBadRequest, "VALIDATION_ERROR", "name required", map[string]any{"field": "name"})
return
}
if len(in.Name) > 200 {
writeError(w, http.StatusBadRequest, "VALIDATION_ERROR", "invalid workflow column name", map[string]any{"field": "name"})
return
}
if err := s.store.UpdateWorkflowColumnName(ctx, project.ID, columnKey, in.Name); err != nil {
writeStoreErr(w, err, true)
return
}
s.emitRefreshNeeded(project.ID, "workflow_column_renamed")
w.WriteHeader(http.StatusNoContent)
return
}

// DELETE /api/board/{slug}/workflow/{key} - delete an empty non-done lane.
if len(rest) == 3 && rest[1] == "workflow" && r.Method == http.MethodDelete {
ctx := s.requestContext(r)
userID, ok := store.UserIDFromContext(ctx)
if !ok {
writeError(w, http.StatusUnauthorized, "UNAUTHORIZED", "unauthorized", nil)
return
}
role, err := s.store.GetProjectRole(ctx, project.ID, userID)
if err != nil || !role.HasMinimumRole(store.RoleMaintainer) {
writeError(w, http.StatusForbidden, "FORBIDDEN", "maintainer or higher required", nil)
return
}
columnKey := strings.TrimSpace(rest[2])
if columnKey == "" {
writeError(w, http.StatusBadRequest, "VALIDATION_ERROR", "invalid workflow key", map[string]any{"field": "key"})
return
}
if err := s.store.DeleteWorkflowColumn(ctx, project.ID, columnKey); err != nil {
writeStoreErr(w, err, true)
return
}
s.emitRefreshNeeded(project.ID, "workflow_column_deleted")
w.WriteHeader(http.StatusNoContent)
return
}

// GET /api/board/{slug}/lanes/{status}
if len(rest) == 3 && rest[1] == "lanes" && r.Method == http.MethodGet {
columnKey := normalizeLaneKey(rest[2])
Expand Down Expand Up @@ -1444,8 +1560,8 @@ func (s *Server) handleBoard(w http.ResponseWriter, r *http.Request, rest []stri
var in struct {
ToColumnKey string `json:"toColumnKey"`
ToStatus string `json:"toStatus"`
AfterID *int64 `json:"afterId"`
BeforeID *int64 `json:"beforeId"`
AfterID *int64 `json:"afterId"`
BeforeID *int64 `json:"beforeId"`
}
if err := readJSON(w, r, s.maxBody, &in); err != nil {
return
Expand Down Expand Up @@ -1959,8 +2075,8 @@ func (s *Server) handleTodos(w http.ResponseWriter, r *http.Request, rest []stri
var in struct {
ToColumnKey string `json:"toColumnKey"`
ToStatus string `json:"toStatus"`
AfterID *int64 `json:"afterId"`
BeforeID *int64 `json:"beforeId"`
AfterID *int64 `json:"afterId"`
BeforeID *int64 `json:"beforeId"`
}
if err := readJSON(w, r, s.maxBody, &in); err != nil {
return
Expand Down
27 changes: 15 additions & 12 deletions internal/httpapi/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ type storeAPI interface {
UpdateProjectImage(ctx context.Context, projectID int64, userID int64, image *string, dominantColor string) error
UpdateProjectName(ctx context.Context, projectID int64, userID int64, name string) error
UpdateProjectDefaultSprintWeeks(ctx context.Context, projectID int64, userID int64, weeks int) error
AddWorkflowColumn(ctx context.Context, projectID int64, name string) (store.WorkflowColumn, error)
DeleteWorkflowColumn(ctx context.Context, projectID int64, key string) error
UpdateWorkflowColumnName(ctx context.Context, projectID int64, key, newName string) error
GetProjectRole(ctx context.Context, projectID int64, userID int64) (store.ProjectRole, error)
CheckProjectRole(ctx context.Context, projectID int64, userID int64, requiredRole store.ProjectRole) error
ListProjectMembers(ctx context.Context, projectID int64, userID int64) ([]store.ProjectMember, error)
Expand Down Expand Up @@ -227,20 +230,20 @@ func NewServer(st storeAPI, opts Options) *Server {
}

return &Server{
store: st,
logger: logger,
maxBody: maxBody,
mode: mode,
hub: hub,
sink: hub,
store: st,
logger: logger,
maxBody: maxBody,
mode: mode,
hub: hub,
sink: hub,
authRateLimit: authRateLimit,
encryptionKey: encKey,
passwordResetAdminLimiter: passwordResetAdminLimiter,
webFS: webFS,
fileSrv: http.FileServer(http.FS(webFS)),
indexHTML: indexHTML,
landingHTML: landingHTML,
swJS: swJS,
passwordResetAdminLimiter: passwordResetAdminLimiter,
webFS: webFS,
fileSrv: http.FileServer(http.FS(webFS)),
indexHTML: indexHTML,
landingHTML: landingHTML,
swJS: swJS,
}
}

Expand Down
Loading
Loading