Return 0 code on help command and pass cli arguments to zig build run #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Looks fine, any idea why your PR doesn't trigger a run? My guess is it has something to do with this line: https://github.com/marler8997/zigup/blob/master/.github/workflows/artifact.yml#L2 |
Contributor
Author
|
Indeed that's it, it needs to be changed to |
Owner
|
Ok could you add a commit to this PR that changes that, then I can see the tests run and merge it. |
iddev5
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #44 I noticed that
zig build run -- --helpis returning 1 while it should return 0 as its a successful execution of a command. After changing it, I found that,