feat: per-command toggle for real-time completion (closes #776)#867
Open
palemoky wants to merge 1 commit into
Open
feat: per-command toggle for real-time completion (closes #776)#867palemoky wants to merge 1 commit into
palemoky wants to merge 1 commit into
Conversation
- add enabled-commands (whitelist) and disabled-commands (blacklist) styles - skip variable assignments and precommands like sudo when matching - never suppress command-name completion; whitelist takes precedence - document the new styles in README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds two
zstyleoptions to selectively enable or disable real-time autocompletion per command, as requested in #776:I used
zstylerather than the plain shell variables originally sketched in the issue, to stay consistent with every other configuration option in the plugin (min-input,ignored-input, etc.).Why
Per #776 (5 👍): users want to hide completions for commands where they aren't helpful (like
ls), or keep them only where they are (likegit/curl), and reduce overhead on slower systems.How
.autocomplete:async:command-disabled, wired into.autocomplete:async:complete(theline-pre-redrawhook) before the async completion machinery starts — so suppressed commands skip the work entirely, addressing the performance motivation.enabled-commands(whitelist) takes precedence overdisabled-commands(blacklist).'kube*')./usr/bin/ls→ls).VAR=valueassignments and precommand modifiers, sosudo lsmatchesls.Tests
sudo, full paths,VAR=assignments, and command-name typing.Closes #776