Skip to content

Conversation

@maksimbormot
Copy link
Contributor

@maksimbormot maksimbormot commented May 16, 2016

Fixes #808

@maksimbormot
Copy link
Contributor Author

@@ -1,5 +1,6 @@
node_modules
dist
.idea
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please include this in your user gitignore, this has nothing to do in a project gitignore

@jpetitcolas jpetitcolas modified the milestone: 1.0 Sep 19, 2016
@jpetitcolas
Copy link
Contributor

These changes may have some drawbacks. Indeed, some API may expect all the entity fields in the request payload, even the non-editable ones. Yet, as far as I understand your PR, you do not send non editable fields anymore.

That's a big BC break, and I am not sure we handle it properly. A better way would be to retrieve the original entry values and to set them back to the API.

Let's postpone it to another version than the 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants