add embedded_list formatter #1210
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyburel
pushed a commit
to remyburel/ng-admin
that referenced
this pull request
Oct 28, 2016
jpetitcolas
suggested changes
Nov 14, 2016
Contributor
jpetitcolas
left a comment
jpetitcolas
left a comment
There was a problem hiding this comment.
Thanks! I got a comment about your code. Moreover, can you add some unit tests? :)
| return function (entry) { | ||
| return { | ||
| name: label, | ||
| value: entry.values[field.name()].map((obj => obj[field.targetFields()[0].name()])) |
Contributor
There was a problem hiding this comment.
Perhaps would it be more coherent to use the same value as for the reference_many?
value: entry.listValues[field.name()].join(', ')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic formatter for embedded_list fields
It would map the array items to the value of the first target field configured