Skip to content

Fix Child Menu Highlight #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Child Menu Highlight #1346

wants to merge 1 commit into from

Conversation

@Phocea
Copy link
Contributor

@Phocea Phocea commented Jun 13, 2017

With previous code the parent menu gets highlighted only when the first child is active and not when any of its children are active.
This change fixes that.

@Phocea
Fix Child Menu Highlight
60ef119 
With previous code the parent menu gets highlighted only when the first child is active and not when any of its children are active.
This change fixes that.
@Phocea
Copy link
Contributor Author

Phocea commented Jun 14, 2017

Actually I am revising my idea on this.
Currently active is used to checked on the parent, if the current url include the given path. In my use case, all of the child menu item have a different path with no common denominator.
So using menu.isActive(path) would only work on a given one... fix for me was to use childmenu.isActive(path), but I suppose this could be done in a template, depending on the need ?

@marmelab marmelab deleted a comment Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Phocea