Skip to content

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Oct 10, 2025

Problem

@react-admin/ra-soft-delete has been updated and we also extracted all headless components and hooks to @react-admin/ra-core-ee. The OSS documentation is out of date though.

Solution

Update the OSS documentation, both standard and headless.

How To Test

  • make docker-doc for standard documentation
  • make doc-headless for headless

Additional Checks

  • The PR targets master for a bugfix or a documentation fix, or next for a feature
  • The documentation is up to date

Also, please make sure to read the contributing guidelines.

@djhi djhi added the RFR Ready For Review label Oct 10, 2025
@slax57 slax57 self-requested a review October 13, 2025 08:00
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise the new doc page is good!

- Restore archived items individually or in bulk
- Track who deleted what and when

It provides drop-in replacements for DeleteButton and BulkDeleteButton.
Copy link
Contributor

@slax57 slax57 Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

erf, not really 😅 (in headless)

Comment on lines +19 to +23
```bash
npm install --save @react-admin/ra-soft-delete
# or
yarn add @react-admin/ra-soft-delete
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we encourage to install ra-core-ee instead? 🤔

Comment on lines +102 to +110
Once your provider has all soft-delete methods, pass it to the `<Admin>` component and you're ready to start using `ra-soft-delete`.

```tsx
// in src/App.tsx
import { Admin } from 'react-admin';
import { dataProvider } from './dataProvider';

const App = () => <Admin dataProvider={dataProvider}>{/* ... */}</Admin>;
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we shouldn't be mentioning <Admin> nor 'react-admin' in this headless doc


```tsx
// in src/dataProvider.ts
import { addSoftDeleteBasedOnResource } from '@react-admin/ra-soft-delete';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please import from ra-core-ee instead (same below)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RFR Ready For Review

Development

Successfully merging this pull request may close these issues.

3 participants