Skip to content

feat: add unified tag management system#97

Open
tdari wants to merge 18 commits into
marmotdata:mainfrom
tdari:column-tags
Open

feat: add unified tag management system#97
tdari wants to merge 18 commits into
marmotdata:mainfrom
tdari:column-tags

Conversation

@tdari
Copy link
Copy Markdown
Contributor

@tdari tdari commented May 10, 2026

Hey @charlie-haley, I finalized the unified tag management feature we discussed in #82

I didn’t add dbt column tags in this PR because we don’t parse them in the plugin yet.

  • Added unified tag management system (new tag core module)
  • Added column-level tags for assets
  • Added data products CRUD and CLI
  • Added glossary tag operations and CLI
  • New DB migrations to move tags to junction tables
  • New Tag related UI components
  • Updated frontend pages for new tag flow
  • Regenerated API client and Swagger docs (a big change list because of this)
  • Minor cleanups across plugin providers

Quick Demo

tags-demo.webm

@tdari tdari marked this pull request as draft May 17, 2026 08:26
@tdari tdari force-pushed the column-tags branch 4 times, most recently from 868750c to 2c36e05 Compare May 20, 2026 21:21
@tdari tdari marked this pull request as ready for review May 22, 2026 19:15
@tdari
Copy link
Copy Markdown
Contributor Author

tdari commented May 22, 2026

I've updated the PR to reflect the latest SDK changes. This version bump will fix the Python SDK CI check issue.

@charlie-haley
Copy link
Copy Markdown
Member

Hey @tdari thanks for the PR! Could you remove the generated client from sdk/go/internal/gen/client

@tdari
Copy link
Copy Markdown
Contributor Author

tdari commented May 31, 2026

Hey @tdari thanks for the PR! Could you remove the generated client from sdk/go/internal/gen/client

@charlie-haley, I removed the changes in sdk/go/internal/gen/client, but we have a couple of issues:

  • CI builds the Go SDK using the latest version of go-swagger, but our Go SDK still pins the older runtime version (v0.29.3). We need to upgrade go-openapi/runtime to fix the CI failure. See the error
    The issue is related to:
    https://pkg.go.dev/github.com/go-openapi/runtime@v0.32.2#ContextualTransport

  • The CLI requires the new Go SDK client, but if I remove the generated client changes, the new client is no longer available. As a result, make server-lint also fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants