Add growable runtime stacks#434
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
runlang | ec8a379 | Commit Preview URL Branch Preview URL |
Apr 26 2026, 03:34 PM |
ec8a379 to
f6a1222
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_stack_check()/run_morestack()so stack use commits additional pages before overflow.Fixes #403
Fixes #404
Implementation Note
This completes growth without copying live stack frames: the runtime reserves each G's maximum stack range up front and doubles the committed portion downward as needed. That preserves active frame pointers and saved contexts while matching the issue's growth behavior and keeping
run_morestack()non-stubbed.Validation
zig fmt src/codegen_c.zigclang-format -i src/runtime/run_scheduler.c src/runtime/run_scheduler.h src/runtime/tests/test_scheduler.czig buildzig build test(passes; command prints the expected negativemissing()diagnostic from the test fixture)zig build test-runtime