fix: specify UTF-8 encoding when reading style files#10
Open
EnragedAntelope wants to merge 1 commit into
Open
Conversation
Python's read_text() defaults to the OS locale encoding on Windows (cp1252), which cannot decode UTF-8 byte sequences in the style .txt files, causing a UnicodeDecodeError at import time. Explicitly passing encoding='utf-8' fixes the crash on all Windows locales. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
EnragedAntelope
force-pushed
the
fix/unicode-decode-styles
branch
from
22a887a to
4469072
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file_path.read_text()innodes/core/predefined_styles.pywas called without an explicit encodingcp1252, which cannot decode UTF-8 byte sequences present in the bundled style.txtfilesUnicodeDecodeErrorat ComfyUI startup, preventing the node from loading entirelyFix: add
encoding='utf-8'to theread_text()call — a single-character change with no behaviour difference on Linux/macOS (where UTF-8 is already the default).Reproduction
Start ComfyUI on a Windows machine with a non-UTF-8 system locale. The node fails to import with:
Test plan
🤖 Generated with Claude Code