Fix syntax for EXTRA_FLAGS variable in entrypoint.sh#65
Merged
Conversation
Since I could not set up the remote access falg to 1, I changed a potential bug that solved the issue and let me use remote access. Using Ubuntu Server 24.04
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the ALLOW_REMOTE_ACCESS=yes environment variable was not working correctly. The issue was caused by quoting $EXTRA_FLAGS in the entrypoint script, which prevented proper shell word splitting of the --bind-all flag. Removing the quotes allows the flag to be passed correctly to the acestream engine.
Changes:
- Remove quotes around
$EXTRA_FLAGSvariable in entrypoint.sh to enable proper shell word splitting
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
This looks great, thank you for fixing this @Javiju555. I'll merge and release this as a new bugfix version v3.1.1 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
I couldn't get remote access to work - the
ALLOW_REMOTE_ACCESS=yesenvironment variable wasn't being recognized andallow_remotewas always set to 0 in the logs.Fix
I found that
$EXTRA_FLAGSwas quoted in the entrypoint script, which prevented the--bind-allflag from being passed correctly to the acestream engine. Removing the quotes fixed the issue.Testing
After this change, remote access works perfectly:
allow_remote=1http://SERVER_IP:6878/webui/api/service?method=get_versionTested on Ubuntu Server 24.04.