Support Method of Moments Distribution Fitting - #79
Merged
Conversation
martinvonk
had a problem deploying
to
github-pages
September 9, 2025 08:45 — with 
GitHub Actions
Failure
GitHub Actions
Failure
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Method of Moments (MM) distribution fitting as an alternative to the default Maximum Likelihood Estimation (MLE) method. The implementation allows users to specify the fitting method when creating standardized index calculations.
Key changes:
- Added
fit_methodparameter to all standardized index functions and the SI class - Enhanced the distribution fitting functionality to support both MLE and MM methods
- Updated documentation and examples to demonstrate the new fitting capability
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/spei/si.py | Added fit_method parameter to all SI functions and class, defaulting to "MLE" |
| src/spei/dist.py | Enhanced Dist class and fit_dist method to support both MLE and MM fitting methods |
| docs/examples/example02_distributions.ipynb | Added example comparing MLE and MM fitting methods with visualization |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.