Skip to content

Conversation

@UlyssesZh
Copy link

No description provided.

@danielparks
Copy link
Contributor

How does this affect the activate-terminal functionality? notify-send is now started in the background, so if both activate-terminal and raise-at-click are set it will raise immediately after sending the notification, and then again after the notification is clicked.

Maybe it would be clearer if those configurations were grouped together in the README? Or maybe instead of having a separate raise-at-click configuration, it should be an option for activate-terminal (i.e. activate-terminal could be set to yes or to at-click).

I don't use desktop Linux, so it’s hard for me to check out.

I’m just an interested user, so feel free to ignore me. :)

@UlyssesZh
Copy link
Author

I’m just an interested user, so feel free to ignore me. :)

No no, I like discussion.

How does this affect the activate-terminal functionality? notify-send is now started in the background, so if both activate-terminal and raise-at-click are set it will raise immediately after sending the notification, and then again after the notification is clicked.

Exactly.

Or maybe instead of having a separate raise-at-click configuration, it should be an option for activate-terminal (i.e. activate-terminal could be set to yes or to at-click).

I can do that without any major refactor, but I don't think the current settings are too confusing.

@UlyssesZh
Copy link
Author

I found that zsh-notify-after-command does not exit if a background command is running because something like this does not exit immediately:

(sleep 5 && echo 'finished' &) | tee

I now fixed this by using nohup to create a new zsh process to run notify-send. Unfortunately this will make it not work if notify-send is a function defined outside (like what is done in tests/_support) instead of an actual command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants