Skip to content

Fix/v0.8.9 docker #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Fix/v0.8.9 docker #677

wants to merge 16 commits into from

Conversation

5u6r054
Copy link
Contributor

@5u6r054 5u6r054 commented Feb 19, 2025

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

teslashibe and others added 15 commits December 3, 2024 09:03
)

- Update twitterscrpaer package
- Change return type from Legacy to *Profile to match twitter-scraper API
- Update import to use imperatrona/twitter-scraper package
- Fix type compatibility with FetchFollowers method
* chore(ci): add GHA pipeline to publish container images

Signed-off-by: mudler <[email protected]>

* Update .github/workflows/images.yml

Co-authored-by: Mario Camou <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>

---------

Signed-off-by: mudler <[email protected]>
Signed-off-by: Ettore Di Giacinto <[email protected]>
Co-authored-by: Mario Camou <[email protected]>
fix(ci): do not copy .env file in the image

Signed-off-by: mudler <[email protected]>
* feat: adds support for scrape tweet by id

* fix: handler

* fix: docs
commit 31f049a
Author: Bob Stevens <[email protected]>
Date:   Mon Jan 20 11:27:27 2025 -0800

    feat: Enhance login verification UI and error handling.

    Improve status updates in the UI by adding dynamic badge updates and alert messages for login verification. Refactor backend responses to include clear status and message fields, and update error messages for better clarity. Simplify Twitter login error handling by directly returning the login status.

commit fb82dfa
Merge: cbd9164 fe0eb07
Author: Bob Stevens <[email protected]>
Date:   Mon Jan 20 10:24:19 2025 -0800

    Merge remote-tracking branch 'origin/release/v0.8.9' into feat-twitter-account-status

commit cbd9164
Author: Bob Stevens <[email protected]>
Date:   Mon Dec 16 16:58:40 2024 -0800

    feat: Add Twitter login verification feature

    Implemented server-side handler and client-side integration to verify Twitter login status by username. Updated templates to include a button triggering the verification and enhanced API routing for the new endpoint. Improved Twitter authentication error handling for better logging and feedback.

commit 7fbcb81
Author: Bob Stevens <[email protected]>
Date:   Thu Dec 12 16:20:47 2024 -0800

    feat - added twitter account fields to status page

    - Enhanced TwitterAccount with LastScraped and LoginStatus.
    - Implemented singleton pattern for TwitterAccountManager.
    - Updated web handler to display Twitter account info in status.html.
    - Added "Verify login" button (functionality pending).
    Next: Implement backend logic for button functionality.

    removed twitter credentials from the AppConfig. They are all isolated to the twitter package.
* feat - added twitter account fields to status page

- Enhanced TwitterAccount with LastScraped and LoginStatus.
- Implemented singleton pattern for TwitterAccountManager.
- Updated web handler to display Twitter account info in status.html.
- Added "Verify login" button (functionality pending).
Next: Implement backend logic for button functionality.

removed twitter credentials from the AppConfig. They are all isolated to the twitter package.

* feat: Add Twitter login verification feature

Implemented server-side handler and client-side integration to verify Twitter login status by username. Updated templates to include a button triggering the verification and enhanced API routing for the new endpoint. Improved Twitter authentication error handling for better logging and feedback.

* feat: Enhance login verification UI and error handling.

Improve status updates in the UI by adding dynamic badge updates and alert messages for login verification. Refactor backend responses to include clear status and message fields, and update error messages for better clarity. Simplify Twitter login error handling by directly returning the login status.

* update dependency versions
* feat: Add login event tracking for Twitter scraper activities

This update introduces `LoginEvent` handling to track authentication events during Twitter scraping operations. It ensures both successful and failed logins are logged, and integrates these events into the event tracking system. This enhancement improves monitoring and debugging of scraper authentication.

* fix: unit tests to include additional parameter that is loginEvent (not used)

* fix test

* updating the version number for the event api calls and fixed path

* feat: Refactor Twitter scrapers to include login event tracking.

resolved conflicts from the addition of loginEvent
Copy link

PR description is too short and seems to not fulfill PR template, please fill in

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 6.85714% with 326 lines in your changes missing coverage. Please review.

Project coverage is 8.89%. Comparing base (119f740) to head (64fbddb).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
pkg/scrapers/twitter/account.go 0.00% 34 Missing ⚠️
pkg/event/event_client.go 0.00% 33 Missing ⚠️
pkg/api/handlers_data.go 0.00% 30 Missing ⚠️
pkg/api/routes.go 0.00% 29 Missing ⚠️
pkg/api/handlers_node.go 0.00% 28 Missing ⚠️
pkg/scrapers/twitter/cookies.go 0.00% 27 Missing ⚠️
pkg/workers/handlers/twitter.go 0.00% 24 Missing ⚠️
pkg/workers/worker_manager.go 0.00% 21 Missing ⚠️
pkg/scrapers/twitter/auth.go 0.00% 18 Missing ⚠️
pkg/scrapers/twitter/tweets.go 0.00% 18 Missing ⚠️
... and 9 more
Additional details and impacted files
@@          Coverage Diff           @@
##            main    #677    +/-   ##
======================================
  Coverage   8.89%   8.89%            
======================================
  Files         99     100     +1     
  Lines       7800    8058   +258     
======================================
+ Hits         694     717    +23     
- Misses      7032    7261   +229     
- Partials      74      80     +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

PR description is too short and seems to not fulfill PR template, please fill in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants