Adding system configuration & event logging to Hydrant #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement firmware log parsing and display in Hydrant, this is merged into eeprom-dev as it needs some UI integration with the work done in this branch
rohansatapathy
requested changes
Dec 31, 2025
Contributor
rohansatapathy
left a comment
rohansatapathy
left a comment
There was a problem hiding this comment.
I'm gonna assume that you tested this with the actual flight computer and bay boards and everything works as expected. I left some comments on the first few files, up to you whether or not you want to address them. If you do, I would recommend applying them to all the other files as well (especially the naming/formatting stuff). I'll give you and Ryan direct merge permissions soon so you can decide what you want to do from here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes error logging since it's needed for the system configuration (the boards respond to configuration over UDP logs). The logging location is currently in the "logs" directory next to wherever the hydrant project files are located. This is temporary since there is a WIP branch with a general logging framework for the entire project, so once that is done and merged, the error logging can be integrated with that framework so that all logs are in a central location.