Skip to content

Conversation

@lowjoel
Copy link
Contributor

@lowjoel lowjoel commented Mar 23, 2025

This is a prerequisite to get our balloon notifications working.

I've merged the code from the systray package from the getlantern/systray package to present a unified API. Further changes will come in the next PR.

@lowjoel lowjoel force-pushed the systray branch 3 times, most recently from 2a79455 to 3979ef7 Compare March 23, 2025 02:23
@lowjoel
Copy link
Contributor Author

lowjoel commented Mar 23, 2025

Hmm it looks like the formatter doesn't work when used from a fork repo context.

@lowjoel lowjoel mentioned this pull request Mar 23, 2025
@masahide
Copy link
Owner

Thanks for the PR!
I’ll give it a proper look over the weekend.

@masahide
Copy link
Owner

#58 (comment)

@masahide
Copy link
Owner

masahide commented Apr 5, 2025

Hmm it looks like the formatter doesn't work when used from a fork repo context.

Could you please run go mod tidy && goimports -w . to clean up the go.mod and go.sum files and format the Go code?

@lowjoel
Copy link
Contributor Author

lowjoel commented Apr 5, 2025

Cool, done that. Once this is merged I'll rebase #58

(seems like my goimports-on-save isn't working)

Copy link
Owner

@masahide masahide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masahide masahide merged commit 8c51d74 into masahide:main Apr 5, 2025
1 check passed
@lowjoel lowjoel deleted the systray branch April 5, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants