Introduce nanopass pre-/postconditions #370
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masak
force-pushed
the
masak/pre-post-conditions
branch
from
e9250fc to
0857ccf
Compare
|
Note to self: have two different ways to flag up broken pre/postconditions: one for temporary stuff and one for permanent stuff. That way, the (excellent) error messages can indicate this and provide better situational guidance. |
masak
force-pushed
the
masak/pre-post-conditions
branch
from
0857ccf to
c09ac6a
Compare
masak
force-pushed
the
masak/pre-post-conditions
branch
3 times, most recently
from
dcc51a6 to
4ce3396
Compare
masak
force-pushed
the
masak/pre-post-conditions
branch
from
95479ec to
f09324c
Compare
The 'translate' method now calls 'do_translate', which is the abstract method that the deriving classes override.
All the preconditions pass, but I'm going to let that slide for now. Soon enough, these will get tested in a natural way as the compiler passes evolve.
No need to use two words.
masak
force-pushed
the
masak/pre-post-conditions
branch
from
f09324c to
1468a7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To-do before merging: rebase on a merged #383.Done.Closes #368.
Work to be done: