Open
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
juliakreutzer
requested changes
Jan 25, 2022
Collaborator
juliakreutzer
left a comment
juliakreutzer
left a comment
There was a problem hiding this comment.
Hi @godide thank you so much for your work!
Are the BLEU reports of 28.5/38.3 or those of 13.6/4.8 correct?
Please add the correct results also to https://github.com/masakhane-io/masakhane-mt/blob/master/language_pairs.md. Thanks!
|
|
||
|
|
||
| ## Results | ||
| - BLEU dev: 28.48 |
Collaborator
There was a problem hiding this comment.
These are great results. Thank you for sharing also the insights into the data processing and the analysis.
| > | ||
| > 2019-11-13 07:44:03,502 dev bleu: 13.64 [Beam search decoding with beam size = 5 and alpha = 1.0] | ||
| > | ||
| > 2019-11-13 07:44:24,289 test bleu: 4.87 [Beam search decoding with beam size = 5 and alpha = 1.0]` |
Collaborator
There was a problem hiding this comment.
How do these results go with the above reported ones?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request benchmark after updating files, model and confirming the attached notebook.