feat: 저장 실패 시 SAVE_FAILED 알림 발송 - #118
Open
sudosubin wants to merge 1 commit into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sudosubin
force-pushed
the
feat/fcm-pin-duplicated
branch
from
August 30, 2026 15:30
5a4e3e5 to
dc8bdc0
Compare
sudosubin
force-pushed
the
feat/fcm-save-failed
branch
from
August 30, 2026 15:30
a09e09c to
9da786e
Compare
sudosubin
force-pushed
the
feat/fcm-pin-duplicated
branch
from
August 30, 2026 15:42
dc8bdc0 to
d2e314e
Compare
sudosubin
force-pushed
the
feat/fcm-save-failed
branch
from
August 30, 2026 15:42
9da786e to
a1b7f28
Compare
sudosubin
force-pushed
the
feat/fcm-pin-duplicated
branch
from
August 30, 2026 15:46
d2e314e to
ce7a265
Compare
sudosubin
force-pushed
the
feat/fcm-save-failed
branch
from
August 30, 2026 15:46
a1b7f28 to
715141c
Compare
sudosubin
force-pushed
the
feat/fcm-pin-duplicated
branch
from
August 30, 2026 15:52
ce7a265 to
0fc589f
Compare
sudosubin
force-pushed
the
feat/fcm-save-failed
branch
2 times, most recently
from
August 30, 2026 16:00
0743dc3 to
986523a
Compare
sudosubin
force-pushed
the
feat/fcm-pin-duplicated
branch
from
August 30, 2026 16:00
0fc589f to
8993972
Compare
sudosubin
force-pushed
the
feat/fcm-save-failed
branch
from
August 30, 2026 16:14
986523a to
b052231
Compare
sudosubin
force-pushed
the
feat/fcm-pin-duplicated
branch
from
August 30, 2026 16:24
36a34b0 to
cc841b2
Compare
sudosubin
force-pushed
the
feat/fcm-save-failed
branch
from
August 30, 2026 16:24
b052231 to
398b208
Compare
sudosubin
force-pushed
the
feat/fcm-pin-duplicated
branch
from
August 31, 2026 11:49
cc841b2 to
d66d70e
Compare
sudosubin
force-pushed
the
feat/fcm-save-failed
branch
from
August 31, 2026 11:49
398b208 to
c67d917
Compare
sudosubin
commented
Aug 31, 2026
sudosubin
commented
Aug 31, 2026
sudosubin
marked this pull request as ready for review
August 31, 2026 13:03
sudosubin
requested review from
KKardy,
labyrinth30 and
minsour
as code owners
August 31, 2026 13:03
sudosubin
force-pushed
the
feat/fcm-pin-duplicated
branch
from
August 31, 2026 13:28
d66d70e to
965caa0
Compare
sudosubin
force-pushed
the
feat/fcm-save-failed
branch
from
August 31, 2026 13:28
c67d917 to
46002c4
Compare
sudosubin
force-pushed
the
feat/fcm-pin-duplicated
branch
from
August 31, 2026 14:11
965caa0 to
e002b2f
Compare
sudosubin
force-pushed
the
feat/fcm-save-failed
branch
2 times, most recently
from
August 31, 2026 14:17
233b1b6 to
f8564c7
Compare
sudosubin
force-pushed
the
feat/fcm-pin-duplicated
branch
2 times, most recently
from
August 31, 2026 14:27
c45047d to
047dfc6
Compare
sudosubin
force-pushed
the
feat/fcm-save-failed
branch
from
August 31, 2026 14:27
f8564c7 to
70e15a5
Compare
sudosubin
force-pushed
the
feat/fcm-pin-duplicated
branch
from
August 31, 2026 15:31
047dfc6 to
700d1ed
Compare
sudosubin
force-pushed
the
feat/fcm-save-failed
branch
from
August 31, 2026 15:31
70e15a5 to
3c99dc2
Compare
sudosubin
force-pushed
the
feat/fcm-pin-duplicated
branch
from
September 1, 2026 01:24
700d1ed to
19273a8
Compare
sudosubin
force-pushed
the
feat/fcm-save-failed
branch
from
September 1, 2026 01:24
3c99dc2 to
4a955b5
Compare
sudosubin
force-pushed
the
feat/fcm-pin-duplicated
branch
from
September 1, 2026 01:31
19273a8 to
0f94dde
Compare
sudosubin
force-pushed
the
feat/fcm-save-failed
branch
from
September 1, 2026 01:31
4a955b5 to
f0e48f4
Compare
sudosubin
force-pushed
the
feat/fcm-pin-duplicated
branch
from
September 1, 2026 01:38
0f94dde to
46b033f
Compare
sudosubin
force-pushed
the
feat/fcm-save-failed
branch
from
September 1, 2026 01:38
f0e48f4 to
bfebc2c
Compare
저장에 실패했음을 저장한 사람에게 알린다(PRD [SYS-002] Flow B). 실패 사유는 구분하지 않는다 — 알림함은 어느 건을 누르든 같은 안내 화면으로 보낸다(EC-013). 발송 지점 세 곳: - 영구 실패(재시도 대상 아님) — 첫 시도에서 바로 - 인식된 장소가 없음 — 저장할 것도 재시도할 것도 없는 경우 - 마지막 배달 — 재시도 소진은 Cloud Tasks가 조용히 버려 워커가 알 수 없어, x-cloudtasks-taskretrycount로 마지막 시도를 판별한다 재시도가 남아 있으면 알리지 않는다. 재시도가 성공할 수 있어 거짓 알림이 된다. key는 저장 시도당 하나라 어느 경로를 거쳐도, 재배달돼도 한 건으로 접힌다.
sudosubin
force-pushed
the
feat/fcm-save-failed
branch
from
September 2, 2026 03:20
bfebc2c to
9f22604
Compare
sudosubin
force-pushed
the
feat/fcm-pin-duplicated
branch
from
September 2, 2026 03:20
46b033f to
b2d1c02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Related Issue
🚀 Description
장소 저장에 실패하면
장소를 저장하지 못했어요.알림을 남깁니다. (PRD [SYS-002] Flow B)이동할 대상이 없는 앱 내 안내 화면으로 가는 유형이라
payload는 null입니다. 실패 사유도 구분하지 않습니다. 알림함은 어느 건을 누르든 같은 안내 화면으로 보냅니다. (EC-013)발송 시점은 세 가지입니다.
재시도 소진은 Cloud Tasks가 조용히 버려서 워커가 알 수 없습니다. 큐는 최대 10회 재시도하는데 소진되면 아무 신호도 오지 않아 저장했는데 아무 소식도 없는 사용자가 생깁니다.
x-cloudtasks-taskretrycount헤더로 마지막 배달을 판별해 그때 알립니다.📢 Notes
CLOUD_TASKS_MAX_ATTEMPTS를 추가했습니다. 기본값이 인프라 설정과 같은 10이라 배포 시 별도 설정 없이 동작합니다. 큐 설정을 바꾸면 이 값도 함께 바꿔야 합니다.POST /rooms/pins는 유효한 Instagram URL을 요구해서 애초에 호출되지 않거나 동기 400을 받습니다. 알림함 행을 남기려면 클라이언트가 실패를 알려주는 경로가 따로 필요합니다.