Open
Conversation
To support type-safe access from Kotlin DSL
|
Hi! I understand this issue has not been merged yet. Do you plan to do it at some point in the future? I have recently moved my Gradle files to Kotlin DSL and I'd like to keep on using your library. Thanks and regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28
Gradle Kotlin DSL automatically generates accessors for each
Extensionfor static type-safe access, but it didn't play well with Ribonizer becauseRibobonizerExtensionwas not public, as described at #28 .Also, I've modified some codes where depends on Groovy's runtime dynamic type resolution. For utilities like
grayRibbonFilter(), I've specified implementation classes likeColorRibbonFilterinstead ofConsumer<BufferedImage>to enable access to options.With this change, you can use Ribbonizer in Kotlin DSL, like:
ribbonizer { builder { variant, iconFile -> when (variant.buildType.name) { "debug" -> yellowRibbonFilter(variant, iconFile).apply { label = branchName } else -> grayRibbonFilter(variant, iconFile) } } }