-
-
Notifications
You must be signed in to change notification settings - Fork 519
Add effect-language-service #13105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add effect-language-service #13105
Conversation
Add effect-language-service package
Update category to be linter
…e-service Remove category on effect-language-service
chrisgrieser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am somewhat hesitant about adding plugins for packages to the registry, since that increases the number of potential packages by a lot, making the registry potentially much harder to maintain.
@other maintainers Any thoughts?
|
Yeah unfortunately packages does not support installation of "subpackage" dependencies like these. Providing them as standalone packages doesn't make sense to me imo. I managed to come pretty far with subpackage support but the implementation was not a good fit for general usage. My understanding of TS plugins specifically is that they're recommended to be installed locally anyways. Does |
|
The reason for this PR is to avoid per-project installations. With the Mason global installation approach, the plugin isn't in the project's I understand the concern about subpackage dependencies. My use case was for personal convenience, and I debated whether to submit this PR given the extra configuration needed. If this doesn't align with mason-registry's architecture or maintenance goals, I completely understand and am happy to close the PR. |
Describe your changes
Adds effect-language-service, a TypeScript language service plugin that provides enhanced diagnostics, refactors, and code actions for Effect-TS projects.
This package is a TypeScript plugin designed to be loaded with
typescript-language-server, not a standalone LSP server. While the official documentation recommends per-project installation with npm, this PR enables global installation with Mason and manual configuration in vim.lsp.config. If this doesn't fit mason-registry's scope, I understand.Evidence on requirement fulfillment (new packages only)
The repository has 316 stars on GitHub at the time of this PR.
Checklist before requesting a review
neovim.lspconfig.Screenshots
Testing details
:MasonInstall effect-language-servicevim.lsp.configwith init_options.plugins.locationpointing to Mason installation@effect/language-servicein node_modulesto verify Mason installation worksExample configuration