Add package for marko-language-server #8350
Conversation
packages/marko-js/package.yaml
Outdated
| - LSP | ||
|
|
||
| source: | ||
| id: pkg:npm/%40marko/[email protected] |
There was a problem hiding this comment.
| id: pkg:npm/%40marko/[email protected] | |
| id: pkg:npm/@marko/[email protected] | |
| schemas: | |
| lsp: vscode:https://raw.githubusercontent.com/marko-js/language-server/@marko/language-server@{{version}}/packages/vscode/package.json | |
| bin: | |
| marko-language-server: npm:@marko/language-server |
We should include the LSP schema with the package specification as well as the binary
There was a problem hiding this comment.
We should include the LSP schema with the package specification as well as the binary
True, but the %40 can stay, has to do with encoding
There was a problem hiding this comment.
| id: pkg:npm/%40marko/[email protected] | |
| id: pkg:npm/%40marko/[email protected] | |
| schemas: | |
| lsp: vscode:https://raw.githubusercontent.com/marko-js/language-server/@marko/language-server@{{version}}/packages/vscode/package.json | |
| bin: | |
| marko-language-server: npm:%40marko/language-server |
Like this
There was a problem hiding this comment.
Yeah the main thing is that the %40 is not necessary here. There are many other packages that just use @ in the npm string and they seem to work. So it seems better to use @ for readability
There was a problem hiding this comment.
Thanks both for the review. It's been a while since I first opened this PR so it's hard to remember clearly, but I believe I was having trouble getting this working without the %40 encoding which is why I included it. I'm on a Windows machine so it might have been something to do with that? Either way I've updated this PR to:
- change the directory to
marko-language-server - add the schema and bin to the config file
packages/marko-js/package.yaml
Outdated
| - LSP | ||
|
|
||
| source: | ||
| id: pkg:npm/%40marko/[email protected] |
There was a problem hiding this comment.
| id: pkg:npm/%40marko/[email protected] | |
| id: pkg:npm/%40marko/[email protected] | |
| schemas: | |
| lsp: vscode:https://raw.githubusercontent.com/marko-js/language-server/@marko/language-server@{{version}}/packages/vscode/package.json | |
| bin: | |
| marko-language-server: npm:%40marko/language-server |
Like this
Describe your changes
Add language server for Marko-js
Issue ticket number and link
Checklist before requesting a review
Screenshots