Skip to content

feat: add plantuml-lsp #9363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add plantuml-lsp #9363

wants to merge 2 commits into from

Conversation

ptdewey
Copy link

@ptdewey ptdewey commented Mar 20, 2025

Describe your changes

Add plantuml-lsp

Issue ticket number and link

Checklist before requesting a review

  • I have successfully tested installation of the package.
  • I have successfully tested the package after installation.

Screenshots

@williambotman williambotman requested a review from a team March 20, 2025 16:04
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some improvements to the package. One thing to note is we are putting in some rules regarding when packages become eligible (similar to nvim-lspconfig). We may need to wait until the project gains some more traction and gets more stars (goal is 100+) or when the project is merged into nvim-lspconfig

@ptdewey
Copy link
Author

ptdewey commented Mar 25, 2025

We may need to wait until the project gains some more traction and gets more stars (goal is 100+) or when the project is merged into nvim-lspconfig

This sounds reasonable to me, I didn't know about the lspconfig 100 star requirement until after I made this PR, so that is on me. It makes sense not to merge until I meet the requirements for merging there also.

@mehalter
Copy link
Member

No worries at all! The requirements were a decision we have made today actually 😅 We are putting together a new maintainer team to help get these PRs processed more quickly and help with the longevity of the project and are discussing lots of things to make sure we can maintain the project well.

@ptdewey
Copy link
Author

ptdewey commented Mar 25, 2025

I was talking about the requirements for merging into nvim-lspconfig there, I hadn't checked them until after I made this PR, and my project definitely doesn't meet those requirements yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants