feat: use OmniSharp/OmniSharp.exe binary provided in the package #9738
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
With the new way how Language Server Config can be provided in neovim, we changed the default binary to match the ones provided inside the package:
See official repo docs how binaries are named in the official package (
OmniSharp
andOmniSharp.exe
):https://github.com/OmniSharp/omnisharp-roslyn?tab=readme-ov-file#building
See new LSP config for OmniSharp:
https://github.com/neovim/nvim-lspconfig/blob/master/lsp/omnisharp.lua#L19
The benefit in doing so, would be that the LSP config does not have to change if the binary is in users PATH, and could be picked up, resulting in hopefully 'just work experience', regardless if the user installed the server manually or with Mason.
Checklist before requesting a review
For MacOS I expect it to work as it works for Linux.