Skip to content

feat: use OmniSharp/OmniSharp.exe binary provided in the package #9738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

616b2f
Copy link

@616b2f 616b2f commented Apr 18, 2025

Describe your changes

With the new way how Language Server Config can be provided in neovim, we changed the default binary to match the ones provided inside the package:

See official repo docs how binaries are named in the official package (OmniSharp andOmniSharp.exe):
https://github.com/OmniSharp/omnisharp-roslyn?tab=readme-ov-file#building

See new LSP config for OmniSharp:
https://github.com/neovim/nvim-lspconfig/blob/master/lsp/omnisharp.lua#L19

The benefit in doing so, would be that the LSP config does not have to change if the binary is in users PATH, and could be picked up, resulting in hopefully 'just work experience', regardless if the user installed the server manually or with Mason.

Checklist before requesting a review

  • I have successfully tested installation of the package (but only on Linux).
  • I have successfully tested the package after installation (but only on Linux).
  • I have successfully tested installation of the package (for Windows, maybe someone could test it please).
  • I have successfully tested the package after installation (for Windows, maybe someone could test it please).

For MacOS I expect it to work as it works for Linux.

@williambotman williambotman requested a review from a team April 18, 2025 10:30
@616b2f
Copy link
Author

616b2f commented Apr 18, 2025

I would keep it as Draft as long as it's not tested for Windows users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant