Skip to content

fix(protocol): consume default outbound slot on dial success, not failure #5102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
damip wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(protocol): consume default outbound slot on dial success, not failure #5102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion massa-protocol-worker/src/connectivity.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,9 @@ pub(crate) fn start_connectivity_thread(
// Default category
None if connection_slots["default"] > 0 => {
// In case the connection succeeds, we take a place in a slot
if try_connect_peer(*addr, &mut network_controller, &peer_db, &config).is_err() {
// (mirrors the special-category branch above: the slot is
// consumed and the address recorded on success, not failure).
if try_connect_peer(*addr, &mut network_controller, &peer_db, &config).is_ok() {
if let Some(v) = connection_slots.get_mut("default") {
*v = v.saturating_sub(1);
}
Expand Down
Loading