Skip to content

[F93] (cache) reorder save_module to check lru_cache first#5130

Open
peterjah wants to merge 1 commit into
mainfrom
5116-f93-inverted-cache-check-order-in-save_module-causes-redundant-work-resource-amplification
Open

[F93] (cache) reorder save_module to check lru_cache first#5130
peterjah wants to merge 1 commit into
mainfrom
5116-f93-inverted-cache-check-order-in-save_module-causes-redundant-work-resource-amplification

Conversation

@peterjah

Copy link
Copy Markdown
Collaborator
  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@peterjah
peterjah requested a review from Leo-Besancon July 23, 2026 08:31
@modship modship changed the title (cache) reorder save_module to check lru_cache first [F93] (cache) reorder save_module to check lru_cache first Jul 23, 2026

@Leo-Besancon Leo-Besancon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, IMO the added test read counter on the hd cache could be removed to avoid bloating, but it's not too many lines so we can also keep it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[F93] Inverted cache-check order in save_module causes redundant work (resource amplification)

3 participants