Skip to content

[F108] add locally produced blocks to checked_headers#5131

Open
peterjah wants to merge 1 commit into
mainfrom
5118-f108-missing-checked-header-cache-update-on-propagated-blocks-enables-reflected-header-cpu-amplification
Open

[F108] add locally produced blocks to checked_headers#5131
peterjah wants to merge 1 commit into
mainfrom
5118-f108-missing-checked-header-cache-update-on-propagated-blocks-enables-reflected-header-cpu-amplification

Conversation

@peterjah

Copy link
Copy Markdown
Collaborator
  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@peterjah
peterjah requested a review from Leo-Besancon July 23, 2026 08:44
@peterjah peterjah changed the title add locally produced blocks to checked_headers [F108] add locally produced blocks to checked_headers Jul 23, 2026

@Leo-Besancon Leo-Besancon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the fact that we insert twice non-local blocks into the cache (both during note_header_from_peer and in the added path here), the fix looks good.
Alternatives would probably require more changes to the codebase to cover all behaviors so that would not be worth it.

So the current PR LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[F108] Missing checked-header cache update on propagated blocks enables reflected header CPU amplification

3 participants