[F108] add locally produced blocks to checked_headers#5131
Open
peterjah wants to merge 1 commit into
Conversation
Leo-Besancon
approved these changes
Jul 23, 2026
Leo-Besancon
left a comment
Member
There was a problem hiding this comment.
Aside from the fact that we insert twice non-local blocks into the cache (both during note_header_from_peer and in the added path here), the fix looks good.
Alternatives would probably require more changes to the codebase to cover all behaviors so that would not be worth it.
So the current PR LGTM!
bilboquet
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resync_checkflag