Skip to content

[F75] gRPC operation stream subscribes before handshake#5139

Open
modship wants to merge 1 commit into
mainfrom
F75
Open

[F75] gRPC operation stream subscribes before handshake#5139
modship wants to merge 1 commit into
mainfrom
F75

Conversation

@modship

@modship modship commented Jul 23, 2026

Copy link
Copy Markdown
Member
  • document all added functions
  • try in sandbox /simulation/labnet
    • if part of node-launch, checked using the resync_check flag
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@modship modship linked an issue Jul 23, 2026 that may be closed by this pull request
[F75] gRPC operation stream subscribes before handshake and gains hidden backlog #5064
Open
Leo-Besancon
Leo-Besancon approved these changes Jul 24, 2026
View reviewed changes

@Leo-Besancon Leo-Besancon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bilboquet bilboquet bilboquet approved these changes
@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[F75] gRPC operation stream subscribes before handshake and gains hidden backlog

3 participants

@modship @bilboquet @Leo-Besancon