revert --bundle-directory to --build-directory and other changes

[chrisghill]

No description provided.

[Copilot]

Pull Request Overview

This pull request updates the flag name from "bundle-directory" to "build-directory" across several commands and removes the deprecated "Access" field from bundle-related schema, data structures, and tests. Key changes include:

• Renaming flags in cmd/bundle.go to align with the updated terminology.
• Removing the "Access" property from TemplateData, bundle publishing, and related schema/test files.
• Updating comments and warnings to reflect changes in deprecated fields and supported configurations.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pkg/templatecache/template_cache.go	Removed the now-deprecated "Access" field from TemplateData.
pkg/commands/publish/package.go	Updated comments to reference terraform/opentofu files instead of provisioner files.
pkg/commands/generate_new_bundle_test.go	Removed deprecated "Access" property in test fixture for TemplateData.
pkg/bundle/schemas/bundle-schema.json	Removed the "access" property from the JSON schema as part of the deprecation.
pkg/bundle/lint_test.go	Removed usage of "Access" in bundle test fixtures.
pkg/bundle/bundle.go	Removed assignment of "Access" and added warning messages for deprecated and incorrect type.
cmd/image.go	Added a check to ensure image management is only used for the supported API URL.
cmd/bundle.go	Renamed the flag "bundle-directory" to "build-directory" in command definitions and usage.

Comments suppressed due to low confidence (2)

pkg/templatecache/template_cache.go:12

• The 'Access' field has been removed from TemplateData; please verify that all dependent logic and tests are updated accordingly to reflect this deprecation.

Access       string            `json:"access"`

cmd/bundle.go:54

• Since the flag has been renamed from 'bundle-directory' to 'build-directory', please ensure that all user-facing documentation and corresponding tests are updated to reflect this change consistently.

bundleBuildCmd.Flags().StringP("build-directory", "b", ".", "Path to a directory containing a massdriver.yaml file.")

[Copilot]

[nitpick] The warning messages for deprecated 'access' and unexpected 'type' values are output using fmt.Println; consider using a proper logging mechanism or emitting warnings to stderr to ensure consistency in production environments.