Support for rejecting out-of-range chunks#2
Merged
Conversation
Debugging why verification blows up so many tests, its hard to tell whats failing because phoenix is swallowing the errors, going to try to switch to cowboy to see if i can see the full trace
if we dont get a chunk range, we have to be OK about that, there is some places in the conf test suite its sent and some its not, i'll dig in to figure out when the spec says to send it, but the way its modeled now, we just accept empty uploads (unless this is another failing test I havent gotten to yet). When we verify, we just assume :ok in this case. I'll do some research on the spec so when its required is more clearn, right now it looks like a hack and it'll definitely permit someone to make a million empty files and it be 'valid' (and expensive) over something like s3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.