fix(ts): coverage only if it passed #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. WalkthroughThe logic for displaying coverage information in test results was updated to ensure that coverage details are only shown when coverage data is present and the test result status is "PASS." Previously, coverage was displayed for any result with coverage data, regardless of status. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Contributor
Below is the Action testing on itself with this PR's source code against policies in
|
| File | Status | Passed | Total | Coverage | Details |
|---|---|---|---|---|---|
| ./examples/tests/ignore-changes-outside-root_test.rego | ✅ PASS | 12 | 12 | 92.86% Uncovered Lines42 |
Show Details✅ test_affected_no_files✅ test_affected_tf_files ✅ test_affected_no_tf_files ✅ test_affected_outside_project_root ✅ test_ignore_affected ✅ test_ignore_not_affected ✅ test_ignore_tag ✅ test_propose_affected ✅ test_propose_not_affected ✅ test_track_affected ✅ test_track_not_affected ✅ test_track_not_stack_branch |
| ./examples/tests/enforce-password-length_test.rego | ✅ PASS | 3 | 3 | 90.91% Uncovered Lines29 |
Show Details✅ test_deny_creation_of_password_with_less_than_16_characters✅ test_warn_creation_of_password_between_16_and_20_characters ✅ test_allow_creation_of_password_longer_than_20_characters |
| ./examples/tests/track-using-labels_test.rego | ✅ PASS | 8 | 8 | 45.45% Uncovered Lines3, 5, 12-13, 23-26, 35, 37-38, 41 |
Show Details✅ test_track_different_branches✅ test_propose_non_empty_branch ✅ test_propose_empty_branch ✅ test_affected_directory ✅ test_affected_extension ✅ test_not_affected_directory ✅ test_not_affected_extension ✅ test_ignore_not_affected |
| ./examples/tests/notification-stack-failure-origins_test.rego | ✅ PASS | 7 | 7 | 96.67% Uncovered Lines80 |
Show Details✅ test_slack_notification_for_tracked_failed_run✅ test_no_slack_notification_for_non_tracked_run ✅ test_no_slack_notification_for_successful_run ✅ test_slack_notification_with_unknown_github_user ✅ test_pr_comment_for_tracked_failed_run ✅ test_no_pr_comment_for_non_tracked_run ✅ test_no_pr_comment_for_successful_run |
| ./examples/tests/do-not-delete-stateful-resources_test.rego | ✅ PASS | 5 | 5 | 85.71% Uncovered Lines34 |
Show Details✅ test_deny_s3_bucket_deletion✅ test_deny_db_instance_deletion ✅ test_deny_efs_file_system_deletion ✅ test_deny_dynamodb_table_deletion ✅ test_allow_instance_deletion |
| ./examples/tests/enforce-module-use-policy_test.rego | ✅ PASS | 3 | 3 | 47.83% Uncovered Lines37, 42, 46, 52, 54, 57, 60-61, 64, 68, 78, 80 |
Show Details✅ test_deny_creation_of_controlled_resource_type✅ test_deny_update_of_controlled_resource_type ✅ test_allow_creation_of_uncontrolled_resource_type |
| ./examples/tests/readers-writers-admins-teams_test.rego | ✅ PASS | 6 | 6 | 83.33% Uncovered Lines16, 24, 28 |
Show Details✅ test_allow_writers✅ test_allow_admins ✅ test_allow_readers ✅ test_space_admin_access ✅ test_space_write_access ✅ test_space_read_access |
| ./examples/tests/cancel-in-progress-runs_test.rego | ✅ PASS | 2 | 2 | 83.33% Uncovered Lines16 |
Show Details✅ test_cancel_runs_allowed✅ test_cancel_runs_denied |
| ./examples/drift-detection.rego | 0 | 0 | N/A | Show DetailsNo test file found |
Report generated by 🧪 GitHub Actions for OPA Rego Test
Contributor
Below is the Action testing on itself with this PR's source code against
|
| File | Status | Passed | Total | Coverage | Details |
|---|---|---|---|---|---|
| examples/tests/cancel-in-progress-runs_test.rego | ✅ PASS | 2 | 2 | 83.33% Uncovered Lines16 |
Show Details✅ test_cancel_runs_allowed✅ test_cancel_runs_denied |
| examples/tests/do-not-delete-stateful-resources_test.rego | ✅ PASS | 5 | 5 | 85.71% Uncovered Lines34 |
Show Details✅ test_deny_s3_bucket_deletion✅ test_deny_db_instance_deletion ✅ test_deny_efs_file_system_deletion ✅ test_deny_dynamodb_table_deletion ✅ test_allow_instance_deletion |
| examples/tests/enforce-module-use-policy_test.rego | ✅ PASS | 3 | 3 | 47.83% Uncovered Lines37, 42, 46, 52, 54, 57, 60-61, 64, 68, 78, 80 |
Show Details✅ test_deny_creation_of_controlled_resource_type✅ test_deny_update_of_controlled_resource_type ✅ test_allow_creation_of_uncontrolled_resource_type |
| examples/tests/enforce-password-length_test.rego | ✅ PASS | 3 | 3 | 90.91% Uncovered Lines29 |
Show Details✅ test_deny_creation_of_password_with_less_than_16_characters✅ test_warn_creation_of_password_between_16_and_20_characters ✅ test_allow_creation_of_password_longer_than_20_characters |
| examples/tests/ignore-changes-outside-root_test.rego | ✅ PASS | 12 | 12 | 92.86% Uncovered Lines42 |
Show Details✅ test_affected_no_files✅ test_affected_tf_files ✅ test_affected_no_tf_files ✅ test_affected_outside_project_root ✅ test_ignore_affected ✅ test_ignore_not_affected ✅ test_ignore_tag ✅ test_propose_affected ✅ test_propose_not_affected ✅ test_track_affected ✅ test_track_not_affected ✅ test_track_not_stack_branch |
| examples/tests/notification-stack-failure-origins_test.rego | ✅ PASS | 7 | 7 | 96.67% Uncovered Lines80 |
Show Details✅ test_slack_notification_for_tracked_failed_run✅ test_no_slack_notification_for_non_tracked_run ✅ test_no_slack_notification_for_successful_run ✅ test_slack_notification_with_unknown_github_user ✅ test_pr_comment_for_tracked_failed_run ✅ test_no_pr_comment_for_non_tracked_run ✅ test_no_pr_comment_for_successful_run |
| examples/tests/readers-writers-admins-teams_test.rego | ✅ PASS | 6 | 6 | 83.33% Uncovered Lines16, 24, 28 |
Show Details✅ test_allow_writers✅ test_allow_admins ✅ test_allow_readers ✅ test_space_admin_access ✅ test_space_write_access ✅ test_space_read_access |
| examples/tests/track-using-labels_test.rego | ✅ PASS | 8 | 8 | 86.36% Uncovered Lines3, 12, 41 |
Show Details✅ test_track_different_branches✅ test_propose_non_empty_branch ✅ test_propose_empty_branch ✅ test_affected_directory ✅ test_affected_extension ✅ test_not_affected_directory ✅ test_not_affected_extension ✅ test_ignore_not_affected#01 |
| ./examples/drift-detection.rego | 0 | 0 | N/A | Show DetailsNo test file found |
Report generated by 🧪 GitHub Actions for OPA Rego Test
Contributor
Coverage reportCaution An unexpected error occurred. For more details, check console
Test suite run success15 tests passing in 1 suite. Report generated by 🧪jest coverage report action from fb2144e |
oycyc
pushed a commit
that referenced
this pull request
May 30, 2025
🤖 I have created a release *beep* *boop* --- ## [2.0.0](v1.2.0...v2.0.0) (2025-05-30) This new release changes how the OPA test commands are executed. Previously, it was executed as a bash script within the `action.yml`. Now, it is executed programmatically with [GitHub's `@action/exec` package ](https://github.com/actions/toolkit/tree/main/packages/exec). This allows the output to be easily fed as JSON and processed. There is also a new input option of `test_mode` which allows the option to test the OPA by the entire package (directory based aka `opa test ./`) or file by file (e.g. `opa test a_test.rego a.rego`). * The end result should be the same if the OPA package is structured properly. * Previously, it was tested file by file, so if tests are failing, to maintain old behavior, use the input `test_mode = file` * If encountering any issues, please be sure to report them! ### ⚠ BREAKING CHANGES * **ts:** use @actions/exec instead of bash script for OPA commands, allow testing entire directory vs file by file ([#27](#27)) ### Bug Fixes * **ts:** coverage only if it passed ([#30](#30)) ([7e4e69c](7e4e69c)) ### Code Refactoring * **ts:** use @actions/exec instead of bash script for OPA commands, allow testing entire directory vs file by file ([#27](#27)) ([9eecaf7](9eecaf7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Reminder:
npm run buildto compile into the distribution/distfolder, which is the source code that the Action uses.Summary by CodeRabbit