-
Notifications
You must be signed in to change notification settings - Fork 2
feat(renovate): enables renovate terraform manager #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new Renovate configuration file ( Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/renovate.json5 (1)
17-21
: Terraform Ignore Paths Configuration.The
"terraform"
block includes an"ignorePaths"
setting to skip updates for files matching"**/context.tf"
. The inline comment clarifies that this is a mixin file. Please double-check that the ignore pattern precisely targets the intended file, avoiding any unintentional exclusions.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/renovate.json5
(1 hunks)
🔇 Additional comments (6)
.github/renovate.json5 (6)
1-5
: Extend Configuration Settings.The configuration extends both
"config:best-practices"
and an external preset"github>aquaproj/aqua-renovate-config#2.7.5"
. This approach leverages established standards while incorporating community-driven best practices. Please ensure that the referenced external version remains up-to-date as new versions are released.
6-8
: Monthly Update Schedule.The
"schedule": ["every month"]
setting clearly defines a monthly update cycle. Verify that this cadence aligns with your team's operational practices and update policies.
9-10
: Automatic Assignment and Dashboard Management.Enabling
"assigneesFromCodeOwners": true
ensures pull requests are directed to the appropriate reviewers based on the CODEOWNERS file. Additionally,"dependencyDashboardAutoclose": true
helps keep the dependency dashboard clean by auto-closing stale issues. Both settings streamline maintenance tasks effectively.
11-13
: PR Labeling Strategy.The configuration adds an
"auto-upgrade"
label to pull requests, which improves visibility and categorization of dependency updates. This label facilitates better triaging and review of upgrade PRs.
14-16
: Terraform Manager Activation.By listing
"terraform"
under"enabledManagers"
, the configuration ensures that Terraform dependencies are specifically targeted for updates. This is particularly useful if the project predominantly uses Terraform.
22-28
: Package Rules for Optional Dependencies.Defining a package rule that matches
"optionalDependencies"
is a thoughtful way to handle non-essential dependencies separately. This improves update granularity and control for optional packages. If future requirements arise, consider extending this rule with further constraints.
.github/renovate.json5
Outdated
"github>aquaproj/aqua-renovate-config#2.7.5" | ||
], | ||
"schedule": [ | ||
"every month" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to set this so it's on the 1st of the month so we get them as the same time as our other monthly PR waves?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable. Updated!
@gberenice just updated this one and put it on your plate since this is something you're actively tackling: https://www.notion.so/masterpoint/Investigate-renovate-aqua-atmos-plugin-for-easy-tofu-upgrades-8267e0592e4b497d8d0d996e29f8b760?pvs=4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 I have created a release *beep* *boop* --- ## [0.3.0](v0.2.0...v0.3.0) (2025-04-10) ### Features * actualize README template ([#15](#15)) ([5d8de5f](5d8de5f)) * **renovate:** enables renovate terraform manager ([#18](#18)) ([e45f5ac](e45f5ac)) ### Bug Fixes * **renovate:** schedule update ([#20](#20)) ([62d7e24](62d7e24)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
what
config:best-practices
and the external presetgithub>aquaproj/aqua-renovate-config
.auto-upgrade
.why
references
config:best-practices
- ci(renovate): use config:best-practices cloudposse/github-action-atmos-affected-stacks#67Summary by CodeRabbit