Fix logger#156
Merged
Merged
Conversation
SONAR_TOKEN is currently not validly configured for this repository, so the scheduled push and pull_request runs of the SonarCloud workflow fail on every commit. Comment out those triggers and keep only workflow_dispatch so the job can still be invoked manually. Restore the original triggers once the token is set up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains a couple of minor changes focused on maintenance and logging improvements.
Workflow configuration update:
pushandpull_requestevents, with a note explaining this is due to the missingSONAR_TOKENconfiguration. The workflow can still be triggered manually. (.github/workflows/sonarcloud.yml)Logging consistency:
getSettingsAndUpdateConfigPanel()to useslf4Loggerinstead oflogger. (CellposeDetectorDescriptor.java)