Improve dialog show spots and divisions#87
Merged
Conversation
added 2 commits
May 6, 2025 15:34
…ibilities and sliding average window sizes
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the dialog for visualizing spot and division counts over time by introducing new UI controls for color selection, visibility toggling, and adjusting the sliding average window size, with all preferences persisted to user settings.
- Refactored SpotAndDivisionCountChart to integrate new controls and persist settings.
- Removed the obsolete ShowSpotAndDivisionCountsOverTimeCommand and updated related plugin integrations.
- Updated GitHub Actions workflows to use the latest Java setup action.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| SpotAndDivisionCountChart.java | Added new UI controls and persistent settings for color, visibility, and sliding window sizes; refactored chart creation and update methods. |
| ShowSpotAndDivisionCountsOverTimeCommand.java | Deleted obsolete command class in favor of the new chart.show() integration. |
| TomancakPlugins.java | Updated integration to use SpotAndDivisionCountChart.show() and injected PrefService dependency. |
| build-pr.yml, build-main.yml | Upgraded Java setup to actions/setup-java@v4. |
Comments suppressed due to low confidence (1)
src/main/java/org/mastodon/mamut/tomancak/divisioncount/SpotAndDivisionCountChart.java:312
- [nitpick] Consider updating the properties of the existing renderer instead of instantiating a new one each time in updateChartColors to preserve any internal state and improve performance.
XYLineAndShapeRenderer spotCountRenderer = createRenderer(spotCountColor, new Rectangle2D.Double( -2, -2, 4, 4 ) );
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
8f9fc54 to
5492899
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following features to the dialog that shows spot counts and division counts per timepoint:
All settings can now be made directly in the dialog.
All settings are persisted as user preference.
The new dialog looks like this: