-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(playground-ui): add processor combobox for breadcrumb navigation #12368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: a687283 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughAdds a new ProcessorCombobox React component and its export, integrates it into the processor page header (replacing prior header group and icon), updates an end-to-end test to expect the combobox, and adds a changeset documenting the UI change. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.changeset/bumpy-parks-look.md:
- Around line 1-5: The changeset description mentions a page header integration
that affects packages/playground/src/pages/processors/processor/index.tsx
(belongs to `@mastra/playground`) but the frontmatter only lists
`@mastra/playground-ui`; fix by either updating the changeset text to only
describe the new processor combobox component within `@mastra/playground-ui` or
add a new changeset entry that lists `@mastra/playground` and describes the page
header integration in
packages/playground/src/pages/processors/processor/index.tsx so the scope
matches the files changed.
🧹 Nitpick comments (1)
packages/playground-ui/src/domains/processors/components/processor-combobox.tsx (1)
38-46: Consider simplifying the filter and map chain.The logic is correct, but you could combine the filter predicate with optional chaining more concisely.
Optional: Simplify with nullish check
const processorOptions = Object.keys(processors) .filter(key => { const processor = processors[key]; - return processor?.phases && processor.phases.length > 0; + return processor?.phases?.length; }) .map(key => ({ label: processors[key]?.name || key, value: key, }));
| --- | ||
| '@mastra/playground-ui': patch | ||
| --- | ||
|
|
||
| Added processor combobox to processor page header for quick navigation between processors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
potential_issue: Changeset scope mismatch.
The description mentions "processor page header" integration, but the frontmatter only lists @mastra/playground-ui. The actual page header integration occurs in packages/playground/src/pages/processors/processor/index.tsx, which belongs to @mastra/playground.
Per coding guidelines: "Check that the description inside the changeset file only applies to the packages listed in the frontmatter."
Either:
- Update the description to focus only on the component addition in
@mastra/playground-ui, or - Add a separate changeset for
@mastra/playgroundto cover the page integration
Option 1: Update description to focus on component only
---
'@mastra/playground-ui': patch
---
-Added processor combobox to processor page header for quick navigation between processors
+Added ProcessorCombobox component for quick navigation between processors📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| --- | |
| '@mastra/playground-ui': patch | |
| --- | |
| Added processor combobox to processor page header for quick navigation between processors | |
| --- | |
| '@mastra/playground-ui': patch | |
| --- | |
| Added ProcessorCombobox component for quick navigation between processors |
🤖 Prompt for AI Agents
In @.changeset/bumpy-parks-look.md around lines 1 - 5, The changeset description
mentions a page header integration that affects
packages/playground/src/pages/processors/processor/index.tsx (belongs to
`@mastra/playground`) but the frontmatter only lists `@mastra/playground-ui`; fix by
either updating the changeset text to only describe the new processor combobox
component within `@mastra/playground-ui` or add a new changeset entry that lists
`@mastra/playground` and describes the page header integration in
packages/playground/src/pages/processors/processor/index.tsx so the scope
matches the files changed.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Adds a
ProcessorComboboxcomponent to the processor page header, matching the pattern already used on agent pages. Now you can quickly switch between processors without going back to the list.The breadcrumb updates from just "Processors" to "Processors > [dropdown]" where the dropdown shows all available processors and navigates on selection.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.