Bug fixes#143
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
==========================================
- Coverage 98.92% 98.38% -0.55%
==========================================
Files 34 38 +4
Lines 1400 1545 +145
==========================================
+ Hits 1385 1520 +135
- Misses 15 25 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Changes: - Compute `Feed.guid` from the URL only in `create_from()`, matching `get_by_url()` and `create_stub()`. Previously, Atom feeds whose `<id>` differed from the URL produced a guid that lookups could never find, so the second `planet_add_feed` call collided on the unique constraint instead of reporting "already exists". - Add a data migration that recomputes existing rows' guids using `md5(url)`. - Add regression tests covering guid consistency and the re-add command flow.
…mock helpers Changes: - Skip entries in PostManager.create_from() when a post with the same URL already exists, returning None instead of crashing on the guid UNIQUE constraint. - Extract shared _make_feed_data / _make_entry_data test mock builders into tests/mocks.py, replacing three duplicated copies across two test files. - Add tests covering the manager-level skip and the planet_add_feed command path.
Changes: - Drop invalid RelatedOnlyFieldListFilter pairing on feed__language (CharField) and feed__is_active (BooleanField), which raised NotRelationField and returned HTTP 500. - Add regression tests covering the Blog changelist load and language filter.
36a035c to
de4e35c
Compare
…arch Changes: - Bind the search form when q is in GET (was checking a search param the form never sends), so the navbar can repopulate after submitting - Render the input value and the selected <option> from the bound form, and source options from the form's choices so the missing "Feeds" entry reappears - Add regression tests covering both the populated and empty navbar states
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.