Skip to content

Bug fixes#143

Merged
matagus merged 5 commits into
mainfrom
bug-fixes-may-2026
May 9, 2026
Merged

Bug fixes#143
matagus merged 5 commits into
mainfrom
bug-fixes-may-2026

Conversation

@matagus
Copy link
Copy Markdown
Owner

@matagus matagus commented May 9, 2026

  • Fix planet_add_feed crash on duplicate post URL and deduplicate test mock helpers
  • Fix IntegrityError when re-adding an existing feed via planet_add_feed
  • Fix Blog admin changelist crash on language/is_active filters
  • Fix navbar search form losing query and dropdown selection after a search
  • Bump version to 1.1.0

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 9, 2026

Codecov Report

❌ Patch coverage is 98.56115% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.38%. Comparing base (5301f5d) to head (edecdb7).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
planet/migrations/0003_fix_feed_guid.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   98.92%   98.38%   -0.55%     
==========================================
  Files          34       38       +4     
  Lines        1400     1545     +145     
==========================================
+ Hits         1385     1520     +135     
- Misses         15       25      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

matagus added 3 commits May 9, 2026 13:19
Changes:
  - Compute `Feed.guid` from the URL only in `create_from()`, matching `get_by_url()` and `create_stub()`. Previously, Atom feeds whose `<id>` differed from the URL produced a guid that lookups could never find, so the second `planet_add_feed` call collided on the unique constraint instead of reporting "already exists".
  - Add a data migration that recomputes existing rows' guids using `md5(url)`.
  - Add regression tests covering guid consistency and the re-add command flow.
…mock helpers

Changes:
  - Skip entries in PostManager.create_from() when a post with the same URL already exists, returning None instead of crashing on the guid UNIQUE constraint.
  - Extract shared _make_feed_data / _make_entry_data test mock builders into tests/mocks.py, replacing three duplicated copies across two test files.
  - Add tests covering the manager-level skip and the planet_add_feed command path.
Changes:
  - Drop invalid RelatedOnlyFieldListFilter pairing on feed__language (CharField) and feed__is_active (BooleanField), which raised NotRelationField and returned
  HTTP 500.
  - Add regression tests covering the Blog changelist load and language filter.
@matagus matagus force-pushed the bug-fixes-may-2026 branch from 36a035c to de4e35c Compare May 9, 2026 18:19
matagus added 2 commits May 9, 2026 14:00
…arch

Changes:
  - Bind the search form when q is in GET (was checking a search param the form never sends), so the navbar can repopulate after submitting
  - Render the input value and the selected <option> from the bound form, and source options from the form's choices so the missing "Feeds" entry reappears
  - Add regression tests covering both the populated and empty navbar states
@matagus matagus merged commit cdd5005 into main May 9, 2026
21 checks passed
@matagus matagus deleted the bug-fixes-may-2026 branch May 9, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants