Skip to content

Clarify member contact info - #120

Merged
matanp merged 7 commits into
mainfrom
clarify-member-contact-info
Sep 20, 2026
Merged

matanp merged 7 commits into
mainfrom
clarify-member-contact-info

Conversation

@matanp

@matanp matanp commented Sep 20, 2026

Copy link
Copy Markdown
Owner

No description provided.

matanp and others added 7 commits September 18, 2026 21:46
Replace the "Contact info for this submission" label on the add/request
forms with a shared ContactInfoLabel that names the member being added
and explains via an info tooltip that the values are stored with the
committee submission, not on the voter record.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Preflight hard stops and warnings were rendered by both
EligibilitySnapshotPanel and AddCommitteeForm's own alerts, and a
server-side INELIGIBLE rejection additionally fired a toast. Give each
signal one owner: the snapshot panel renders preflight results, the
form's "Cannot add member" alert renders submit-time rejections, and
the toast is dropped. Reset alerts only when the selected candidate
changes, and retitle the preflight alert since nothing was submitted.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
… selected

Move the membership-type select and contact-info inputs in AddCommitteeForm
from above the search into the eligibility panel, so they only appear after
an admin selects a candidate. Name the selected member in the contact-info
label ("Contact info for <name>") in both the admin add form and the
non-admin request form so the fields unambiguously read as the member's,
not the submitter's. Clear contact inputs on each new search, and render
AddCommitteeForm above the roster instead of below it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…leaders

Implements docs/SRS/tickets/P2-committee-detail-interim-layout.md:
- Title is the committee identity alone; summary block renders first.
- Add-member workflow sits behind an "Add committee member" disclosure
  (aria-expanded, closed by default, closes after a successful add; the
  form stays mounted so search/eligibility state survives toggling).
- LTED total weight lives in a "Committee settings" card; sections use
  neutral headings with consistent spacing.
- Drops the inner "Add Committee Member" h1 and demotes search-result
  headings.

Also: leaders whose jurisdictions cover exactly one city/LD scope land
on that roster directly, with the city/LD pickers replaced by a label.
Derived server-side from the filtered committee lists via
singleCommitteeScope(); no auth or API changes.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…t, and issue map

Adds the Committee Operations Workspace UI implementation plan, the P2
interim detail-layout ticket it supersedes at cutover, the 9/17 user
feedback notes that motivated both, and the .scratch/committees-workspace
issue map with its 16 execution tickets.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…open

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
voter-file-tool-2 Building Building Preview Sep 20, 2026 3:08am UTC

@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 338365bc-1e4d-40b7-a182-b9623fd7482a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@matanp
matanp merged commit a42449e into main Sep 20, 2026
3 of 4 checks passed

This branch was successfully deployed

1 active deployment
Preview — c3656903 Deployed Sep 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant