fix: handle null IDs and token in virtual heater#39
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| if (poolID == null || systemID == null || token == null) { | ||
| logger.warn("haywardCommand missing configuration (poolID={}, systemID={}, token={})", poolID, | ||
| systemID, token); |
There was a problem hiding this comment.
[P1] Stop logging authentication token
The warning emitted when any of poolID, systemID, or token is null logs the raw token value even when only one of the other fields is missing. The token is an account credential and this statement now leaks it at WARN level whenever misconfiguration occurs. Consider omitting the token entirely or masking it so that secret material is never written to logs.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing
./mvnw -q -pl bundles/org.openhab.binding.haywardomnilogiclocal -am test(fails: Failed to fetch https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.11/apache-maven-3.9.11-bin.zip)mvn -q -pl bundles/org.openhab.binding.haywardomnilogiclocal -am test(fails: Non-resolvable parent POM org.openhab:openhab-super-pom:[1.0, 2.0))https://chatgpt.com/codex/tasks/task_e_68c0ad052e00832381cd082bc903b8c2