Skip to content
Open

done #3076

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"license": "GPL-3.0",
"devDependencies": {
"@mate-academy/eslint-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^2.1.3",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^28.6.0",
"eslint-plugin-node": "^11.1.0",
Expand All @@ -26,6 +26,5 @@
},
"mateAcademy": {
"projectType": "javascript"
},
"dependencies": {}
}
}
25 changes: 25 additions & 0 deletions src/makeCalculator.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,31 @@
*/
function makeCalculator() {
// write code here
return {
result: 0,
add(num) {
this.result += num;
},
subtract(num) {
this.result -= num;
},
multiply(num) {
this.result = this.result * num;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: use arithmetic operators with assignment operator = if you want to add something to existing value. Instead of this.result = this.result * num;, use the *= operator as in the provided good example.

},
divide(num) {
this.result = this.result / num;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also violates checklist item #2: use arithmetic operators with assignment operator = if you want to add something to existing value. Instead of this.result = this.result / num;, use the /= operator.

},
operate(callback, num) {
callback.call(this, num);

return this;
},
reset() {
this.result = 0;

return this;
},
};
}

module.exports = makeCalculator;
Loading