-
Notifications
You must be signed in to change notification settings - Fork 3k
done #3076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
done #3076
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| name: Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ master ] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - run: npm test |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,31 @@ | |
| */ | ||
| function makeCalculator() { | ||
| // write code here | ||
| return { | ||
| result: 0, | ||
| add(num) { | ||
| this.result += num; | ||
| }, | ||
| subtract(num) { | ||
| this.result -= num; | ||
| }, | ||
| multiply(num) { | ||
| this.result = this.result * num; | ||
| }, | ||
| divide(num) { | ||
| this.result = this.result / num; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This also violates checklist item #2: |
||
| }, | ||
| operate(callback, num) { | ||
| callback.call(this, num); | ||
|
|
||
| return this; | ||
| }, | ||
| reset() { | ||
| this.result = 0; | ||
|
|
||
| return this; | ||
| }, | ||
| }; | ||
| } | ||
|
|
||
| module.exports = makeCalculator; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This violates checklist item #2:
use arithmetic operators with assignment operator = if you want to add something to existing value. Instead ofthis.result = this.result * num;, use the*=operator as in the provided good example.